| CARVIEW |
Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll Perfetto Trace Processor Win from 8f17bc081289 to b8036a07d4c3
https://android.googlesource.com/platform/external/perfetto.git/+log/8f17bc081289..b8036a07d4c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Icea0b1320ffdbefc8b30ee6fa3d5b14b0e8bb4cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032848
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528444}
[segmentation] Mechanical: Migrate ios_module_ranker to new API
Change-Id: I54c557ee7085683bd893c8edaccbec7a9be1f4f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7019721
Auto-Submit: Siddhartha S <ssid@chromium.org>
Reviewed-by: Hailey Wang <haileywang@google.com>
Commit-Queue: Hailey Wang <haileywang@google.com>
Cr-Commit-Position: refs/heads/main@{#1528443}
[segmentation] Mechanical: Migrate password_manager_user_segment to new API
Change-Id: I74d76aa2616057d49964f1c31f5d66575aea4803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7019731
Reviewed-by: Hailey Wang <haileywang@google.com>
Commit-Queue: Hailey Wang <haileywang@google.com>
Cr-Commit-Position: refs/heads/main@{#1528442}
Roll Catapult from 08cc56f0f4b3 to 67287c8f0b4e (2 revisions)
https://chromium.googlesource.com/catapult.git/+log/08cc56f0f4b3..67287c8f0b4e
2025-10-10 hypan@google.com Optimize the StopRecording logic in logcat monotor.
2025-10-10 eduardoyap@google.com feat: Add bot and benchmark filtering to skia_export
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC browser-perf-engprod@google.com,eduardoyap@google.com,johnchen@chromium.org,maximsheshukov@google.com,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: chromium:425720132,chromium:439977560
Tbr: eduardoyap@google.com,maximsheshukov@google.com
Change-Id: I134780d15cc89e42afac69e4e37e6637a90f8869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033396
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528441}
Fix gen_dbus_interface for ClangTidy nested-namespace warning.
This combines nested namespaces into a single block:
namespace remoting::Foo {
...
} // ...
If the source XML has more than 1 interface, they will all be written
out like this. But in that case, we probably want to put them into
separate header files.
Change-Id: I948ade4a5a7a4ec1622d11878d123f8ed90c4f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032453
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528440}
Move to an options variant for Show method in GlicInstanceImpl
This CL introduces `ShowOptions` as a variant to manage different Glic UI embedder types, such as the side panel and floating UI. This change improves type safety and decouples conversation switching logic from the specific UI embedder. `ShowOptions` also allows passing additional information for showing a UI that doesn't belong in the `EmbedderKey`.
Key changes:
- Introduced `glic::ShowOptions`, `glic::SidePanelShowOptions`, and
`glic::FloatingShowOptions` to represent different ways to show the
Glic UI.
- Removed the now-unnecessary `GlicInstanceImpl::EmbedderType` enum in
favor of the `ShowOptions` variant.
- Updated `GlicInstanceImpl` and `GlicInstanceCoordinatorImpl` to use
`ShowOptions`.
- `SwitchConversation` is now embedder-agnostic, simplifying the logic.
Fixed: b:450562729, b:450680703
Change-Id: I6a6a6964f47c81e352dd03461ff06d53153dc202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032584
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528439}
Set CardInfoRetrieval IPH flag to ENABLED_BY_DEFAULT
Bug: 449636634
Change-Id: Ie8467dcdd85d2f00ddf91909f970526d2c1fe267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029999
Commit-Queue: Harsh Shukla <hvs@google.com>
Reviewed-by: Jiali Huang <jialihuang@google.com>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528438}
Update page content store to support overwrites
Delete the old contents and update with new contents.
Bug: 440643544
Change-Id: I4c8a26286b3e05540d860545b2a54d62e0048dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7023720
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528437}
Roll Chrome Android ARM64 Orderfile from 9jCFHdEnsTidFSJEV... to bKkW9aQblTsLAa-nn...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC clank-build@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: clank-library-failures@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I43479005ab4cc6444b7d5dc82889cd6e3ee351c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033270
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528436}
Import wpt@4d84f1442ab18c35bd976fc6815bf3071e35a809
https://github.com/web-platform-tests/wpt/compare/3d8c4c3d0...4d84f1442
Using wpt-import in Chromium 2c8b9a6318b73a58951387bea830b9a0ba67e1a7.
With Chromium commits locally applied on WPT:
468e313cf6 "[BackdropFilter] Create a backdrop root for clip [...]
bf882df84a "[SAA] Fix test failures due to default cookie [...]
844f0be7b6 "Fix document.caretPositionFromPoint().offset for [...]
adc0b917f1 "Reland "Extend timeout duration in reporting-common.js""
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
dcheng@chromium.org, jarhar@chromium.org:
external/wpt/domxpath
NOAUTOREVERT=true
No-Export: true
Validate-Test-Flakiness: skip
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Cq-Include-Trybots: luci.chromium.try:mac15.arm64-blink-rel
Change-Id: I210213d445f442743ca123333265c3953bd33cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030623
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528435}
Roll androidx from B9bWqdm0gg9HN4mil... to hEdm5RV4e3n-OJzHk...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-emulator
Tbr: clank-library-failures@google.com
Change-Id: I6cb67b8d8962b6e389d3d7d6d7eddfe19612d259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030056
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528434}
Roll Dawn from 515c67fd2e81 to 6eaca02da84c (8 revisions)
https://dawn.googlesource.com/dawn.git/+log/515c67fd2e81..6eaca02da84c
2025-10-10 cwallez@chromium.org [github] Use macos-15-intel builder instead of macos-13
2025-10-10 kainino@chromium.org [github] Test that webgpu_cpp.h compiles under CMake
2025-10-10 gman@chromium.org Add a comment to explain why the assert in ~Result
2025-10-10 shrekshao@google.com [WebGPU Backend] Implement CopyFromStagingTo*
2025-10-10 shrekshao@google.com [WebGPU backend] Remove 2 end2end suppressions
2025-10-10 bsheedy@google.com Add dawn_wasm to gn_v2 Mac builders
2025-10-10 cwallez@chromium.org [dawn][node] Validate mappedAtCreation requires size%4==0
2025-10-10 bsheedy@google.com Target arm64 for Mac try builds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:413053623,chromium:440123094,chromium:450046603,chromium:450675299
Tbr: cwallez@google.com
Change-Id: I27715c60df6a80eb41b346dffeda0c5ddaa6d4cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033386
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528433}
Boca: Implement AudioCapturer to provide CRD host audio
This change introduces `AudioCapturerChromeOs`, an implementation of the
`AudioCapturer` interface to support capturing system audio for CrOS
CRD hosts.
`AudioCapturerChromeOs` is created by CRD and manages the overall state
of the audio capture and provides the captured audio packets back to
CRD.
Interactions with CRAS (ChromeOS Audio Server) must occur on the
dedicated audio thread. To achieve this the helper class
`AudioHelperChromeos` is introduced and owned by
`AudioCapturerChromeOs`.
Bug: b/449194420
Change-Id: I3f6f93f1e32aa4835ee5aa1ec35a7826f053dad1
Tests: remoting_unittests --gtest_filter=*AudioCapturerChromeOsTest*
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7023837
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528432}
[omnibox][webui] Adds performance metrics
Provide more accurate and focused metrics for the Omnibox WebUI Popup
by reviving existing performance metrics and refactoring how they are
reported.
* `Omnibox.Popup.WebUI.ConstructionToFirstShownDuration`:
* Measures time from WebUI load to first popup appearance.
* `Omnibox.Popup.WebUI.PageRemoteIsBoundOnFirstCall`:
* Tracks if the WebUI page is ready on the first handler call.
* `Omnibox.Popup.WebUI.ResultChangedToRepaintLatency.ToPaint`:
* Measures the latency between results being available in the
browser process to ready to be shown in WebUI
* `Omnibox.WebUI.CharTypedToRepaintLatency.ToPaint`:
* Measures the latency between keystroke and results ready to be
shown in WebUI. This is exclusive to full WebUI Omnibox.
The latter two metrics are now configurable via `loadTimeData`.
This change also:
* Moves MetricsReporter usage exclusively into WebUIOmniboxHandler,
removing it from base and other derived searchbox handlers. This
means only the WebUI Omnibox will report these metrics.
* Merges `omnibox_popup_view_webui_test.h/cc` into
`omnibox_popup_view_webui_interactive_uitest.cc` to consolidate test
code.
* Improves the `WaitForHandler` test utility to reliably wait for the
page remote to be bound.
* Simplifies `OmniboxPopupPresenter` and `OmniboxPopupWebUIContent` by
deleting now unused accessors
OBSOLETE_HISTOGRAMS=`Omnibox.WebUI.FirstUpdate`, `Omnibox.WebUI.HandlerReadyOnFirstAccess`, `Realbox.CharTypedToRepaintLatency.ToPaint`, and `Realbox.ResultChangedToRepaintLatency.ToPaint`.
Bug: b:450856016
Change-Id: If0635813617277ef612f637aa79b2ed4fae42033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7031002
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528431}
Remove RadioInputNextKeyboardFocusable & RadioKeyboardFocusableOptimize
Both shipped in M140, and can be removed now in M143.
Bug: 427520278, 421837104
Change-Id: I52765dcc144f88eb2dc3524126ca60ee0f0c9ec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7007962
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528430}
Update TestExpectations for simple-input-output.https.html
Investigated potential timeout issues in:
the-audioworklet-interface/simple-input-output.https.html
The investigation confirmed the test is implemented correctly, but
the test has been flaky on MSAN with unknown reasons. To suppress
the warning during the further investigation, this CL updates
the expectations to Crash, Timeout, and Pass.
Bug: 446563923
Change-Id: I88b85c3768816dccaf340c2655a86f6fc95b673a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7027377
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528429}
[Masonry] Remove requirement that the new running position will always
be greater after an item is placed
When there are negative margins on an item, flex and block layouts don't
leave a gap the way grid does, and places the following item directly
after the item. This change follows that convention in masonry. An issue
has been created: https://github.com/w3c/csswg-drafts/issues/12918 which
may lead us to change this behavior.
This also removes a check that the new running position in a track will
always be greater after an item is placed; that DCHECK is inherently
wrong when we have items with negative margins in the stacking axis.
Bug: 343257585
Change-Id: I16eaab2423f0de949b51fa462a00b2fcb268ad02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7027058
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Celeste Pan <celestepan@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1528428}
[omnibox] Add future steady state placeholder
Added string for potential future omnibox placeholder text: "Ask
Google...". No usage of the string yet.
Bug: b:449789409
Change-Id: I274d5bdefd08f5d98e5eccfbbd8f55faf288e9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7018200
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Reviewed-by: Ananya Seelam <ananyaseelam@google.com>
Commit-Queue: James Leung <jamesleung@google.com>
Cr-Commit-Position: refs/heads/main@{#1528427}
Add a CI builder for prompt evals
This builder runs the eval_prompts recipe to evaluate the gemini cli
environment for chromium. It will eventually be a compilator-like
builder that gets launched by a parent builder to shard the tests but
we only have a few evals right now so this will just run all of them.
BYPASS_RECITATION_REASON=The finding is on generated code
Bug: 445458673
Change-Id: I1da5e6c78587b9e302aa55e3c92fe442436a8852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029871
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Cr-Commit-Position: refs/heads/main@{#1528426}
[rust] Import some Rust codelab exercises into the Chromium tree.
There is a Rust codelab for Chromium!
However it lives on an external site: https://google.github.io/comprehensive-rust/exercises/chromium/interoperability-with-cpp.html
And, crucially, the exercise solutions exist as a series of abandoned
CLs, back in the days when checking Rust into the Chromium tree was a
more involved affair: https://chromium-review.googlesource.com/c/chromium/src/+/5096560/1
However, they risk bitrotting and/or not applying cleanly in that state.
So, let's check the exercise code into the Chromium tree.
I've made some modifications to that end:
* The patchsets assume you'll just make changes to the same files
progressively. However, I think it's a little nicer if each exercise
produces a standalone set of targets, so that people can build them
separately, only look at the exercises they care about, etc, so I've
separated each solution out into its own thing.
* The patchsets relied on adding demo code to //ui/base; I've made these
targets self-contained so they won't touch any outside code.
This imports the first four exercises from the codelab. Importing the
subsequent exercises will be done in a separate CL (since I suspect we
may want to tweak the third_party code lab a bit, and thus I'd want that
to be separated out).
Change-Id: I0fa0e6c1941ce381e9bc12fdb04127e8d2c24386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030712
Commit-Queue: Julia Hansbrough <flowerhack@google.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528425}
Roll vulkan-deps from 049bb3a6185f to d6a544e2bf8b (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/049bb3a6185f..d6a544e2bf8b
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b9997dafc791634ce51f6bed7ab886ea0e600a15..6d43afe9a0ef71712d8cec5b0ce0cd3570d1fd41
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/faf69f66f2d9ba782fe37cabd19b9742f9f62eb3..17c41541e8e43364af6ccb4a6ce167274152cd7a
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/caf0bd6ffbb5852953c6dc16a50ca31c1dd373ca..dba3f53b192c4d0b6ecdddaa593ca30f1ceacf2b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC angle-team@google.com,cwallez@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,webgpu-developers@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel
Bug: None
Tbr: cwallez@google.com,radial-bots+chrome-roll@google.com,ynovikov@google.com
Change-Id: If3b69b4cdebc8bebcea2fcb6faf6f22983e9bc02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033384
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528424}
Roll ANGLE from 62fe67a7b6e3 to 8ed16003f271 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/62fe67a7b6e3..8ed16003f271
2025-10-10 timvp@google.com tests: Fix ShadingRateEXTTest.FragmentShadingRatePrimitive
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Test: Test: ShadingRateEXTTest.FragmentShadingRatePrimitive
Change-Id: Ibb641b66cbbb3566e33015aa716abf2954a25dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033378
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528423}
Add argument comments for OnAmountExtractionReturn
Bug: 444684349
Change-Id: I474ca3b5fe7e19abe3d90846a59ecc6c0c014d64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032429
Commit-Queue: James Sun <jamessun@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Qihui Zhao <qihuizhao@google.com>
Cr-Commit-Position: refs/heads/main@{#1528422}
Roll infra/chromium repo to add module scheme to gpu targets
Includes changes:
https://chromium-review.googlesource.com/c/infra/chromium/+/7004570
https://chromium-review.googlesource.com/c/infra/chromium/+/6962959
Change will allow the gpu_targets to override the module_scheme set by the binaries. Other change generates a markdown file that shows what cq builder runs which test suite.
Bug: 440384377
Change-Id: I773d613b318f78aeb7c679607882d6c609b78356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032451
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Benjamin Joyce (Ben) <bjoyce@google.com>
Cr-Commit-Position: refs/heads/main@{#1528421}
[Service Workers] Always notify sync observers of stop/stopping
ServiceWorkerContextCore notifies both asynchronous and synchronous
observers when a service worker's running state changes. Observers
implementing ServiceWorkerContextObserverSynchronous (e.g.
extensions::ServiceWorkerState) rely on receiving immediate
notifications (OnStoppingSync/OnStoppedSync) when a worker stops. This
is critical for maintaining consistent state during operations like
extension unloading/deactivation.
However, ServiceWorkerContextCore sends these synchronous notifications
conditional to the existence of service worker running info tracked in
ServiceWorkerContextWrapper. That's populated *asynchronously* when it
processes the OnStarted notification.
This introduces a race condition: if a worker starts and then stops
rapidly, the synchronous stop handling can occur before the asynchronous
start notification is processed:
- Worker transitions to kRunning.
- Async task is posted for OnStarted.
- Before the task runs, the worker transitions to kStopping.
- OnRunningStateChanged for Stopping checks wrapper's running info.
- Since OnStarted hasn't run, the wrapper reports no running info.
- The synchronous OnStoppingSync notification is skipped.
This leaves synchronous observers in an inconsistent state where they
believe the worker is still active, when it was actually stopping or
stopped. This behavior is not just theoretical: it was actually observed
in https://crrev.com/c/7007249?checksPatchset=7&tab=checks
This change ensures synchronous stopping notifications are always sent.
Bug: 40805401, 40936639
Change-Id: I1dab5e15ff618f5974151b781471ece080738670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029542
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Andrea Orru <andreaorru@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528420}
Fixes and improvements to tab context extraction metrics
Main changes are:
* Added error metric logging for `GetContextFromTab` and
`GetContextForActorFromTab` under the updated
`Glic.Api.{TabContextOperation}.Error.{Mode}` histogram series.
* Un-focusable tab errors when executing `GetContextFromFocusedTab` are
now reported as `PermissionDenied` (instead of `TabNotFound`).
* Renamed `GlicGetContextFromFocusedTabError` to
`GlicGetContextFromTabError` to be make it more generic and shared
among different tab context error reporting.
* Obsoleted the `PermissionDeniedWindowNotShowing` bucket of tab context
extraction histograms as these checks are being done at the TypeScript
and reported to metrics differently.
* Updates and additions to automated tests to reflect the executed
changes and improving metrics checking coverage.
* Other minor improvements and simplifications.
Bug: b:433328453, b:450080763, b:448485935
Change-Id: I6a6a696419d625210489186d9b1a2d97b7c7893f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7023084
Reviewed-by: Dan Harrington <harringtond@chromium.org>
Reviewed-by: Bryant Chandler <bryantchandler@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528419}
Built-In AI APIs: Fix WPT GC util function
Various tests were incorrectly using gc(), which is a wpt_internal util.
Use the centralized WPT common/gc.js garbageGollect() function instead.
Fixed: 443911574
Test: WPTs still pass in local runs and wpt.live
Change-Id: I52d5c07f7e641f94c083af69e9caa83a196f9fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032847
Reviewed-by: Brad Triebwasser <btriebw@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Auto-Submit: Mike Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528418}
Increase shards for browser_tests on ASan builders.
browser_tests are timing out on ASan builders.
Bug: 429586257
Change-Id: Idefa5500d0f9b31c443367ca8d94a2cfab324324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030054
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1528417}
Roll Skia from d0f63de2792c to 5d08d357afb4 (1 revision)
https://skia.googlesource.com/skia.git/+log/d0f63de2792c..5d08d357afb4
2025-10-10 fmalita@google.com [pathops] Simplify one_contour
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac14.arm64-blink-rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: I2d5e7f9d2c95951579032f41681f800d91f32d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033392
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528416}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1760126303-b260e594961b923eaebe99cde2bd7e7ac588ccf4-c2c43e203559aa4c7ba4a7df99374ec812a1aad0.profdata to chrome-mac-arm-main-1760133524-ea3890129c4d48abf30d0b4491496be12e7fcc41-f1860fa315866590c4688dd8045e0634bfdb56e3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I21cace5d589a546eab2a2be6d84e9747fa66e046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033453
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528415}
Roll Perfetto Trace Processor Linux from 15bf867fe5ec to b8036a07d4c3
https://android.googlesource.com/platform/external/perfetto.git/+log/15bf867fe5ec..b8036a07d4c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I11a2ba4906f02fed75e2d715675ee4172a4289b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033134
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528414}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1760113908-0fc084d69434cb94c3a582455000feeff2227c47-8bfdfb011d292e31e3626b4f8c3d75b4a88f946d.profdata to chrome-android64-main-1760124191-3f8913c2298f3834f37eab9d27f167b746151390-b521fcdf4de4e9bd1dda4b9b198c398f8c13c0b7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: If1a10aa8d847098876005c16467090897d6bd0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033431
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528413}
[iOS] Implement persist tab context storage cleanup
This code implements functions which are scheduled at browser session
loads to ensure page contexts of web states that are inactive or haven't
been used for over 21 days gets cleaned up from storage.
Bug: 449705185
Change-Id: Ib4f42e455c7a77e8f8de8be88a5e19c3cc854c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7010989
Reviewed-by: Adam Arcaro <adamta@google.com>
Commit-Queue: Charlotte Cloutier <cloutierc@google.com>
Reviewed-by: Nicolas MacBeth <nicolasmacbeth@google.com>
Cr-Commit-Position: refs/heads/main@{#1528412}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1760086554-f13db3ef7f317c367c77ee8e93d58655ed8db01f-e037b9934f1d78fe98c93eeeda6707d94ef0ec9f.profdata to chrome-win32-main-1760108319-9bd340580844c794471788a5692cf554447e01ff-2c5e9d253d760d65c3a4cec87175b6b1d938e0ac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I042db300eaf01016452e8f20c40a36164f94d8d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029958
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528411}
Roll src-internal from 11b77487bf1c to 70b8a10edca3 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11b77487bf1c..70b8a10edca3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,mpearson@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:446000305
Tbr: mpearson@google.com
Change-Id: I3fd7a3f66dee350006fcff47af115127cdefdb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033278
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528410}
[Side Panel Glic] Fix keyboard handling
This moves the keyboard event handler out of WebuiContentsContainer,
where it was relying on old infrastructure for getting a widget.
Instead, this uses GlicView as the WebContentsDelegate. GlicView
always knows the widget it's in (if any).
Fixed: b:448383934
Change-Id: I8059681125223b68afb44eebe05bde7f3112abe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032284
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528409}
[iOS] Fix histogram mismatch for recording the index of the gallery.
Bug: 450967827
Change-Id: If838d9a94b695e12ab19b01120f8e4a480825580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032027
Commit-Queue: Cheick Cisse <cheickcisse@google.com>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Auto-Submit: Cheick Cisse <cheickcisse@google.com>
Cr-Commit-Position: refs/heads/main@{#1528408}
[Reader Mode] Add distillation feature to the Test Extension.
This CL implements the core feature of the Readability Test Extension:
The ability to distill a page using Readability.js and view the output
in a reader-friendly format styled after Chrome's Reader Mode.
We now introduce the required symbolic links to the `dom_distiller`
CSS and JS components, ensuring the Test Extension provides an accurate
preview of the production Reader Mode experience. Both "Distill"
(in-place) and "Distill New" (new tab) actions are supported to
accommodate different testing workflows.
Additional refactoring:
* Add `utils.js to de-duplicate the data-transfer logic between
`cloned.js` and `viewer.js`. The helper functions were given
"consume" prefixes to clarify their destructive-read nature.
* Refactor `background.js` to combine duplicated logic for opening new
tabs and updating existing ones.
* Rename namespace `ReadabilityTest` -> `ReadabilityExtension`.
Details:
* Add `viewer.html` / `viewer.js`: A new page to host the final
distilled article content.
* Add `article_processor.js`: A shared module to orchestrate the main
distillation process, from invoking `Readability.parse()` to
generating the final HTML string for the viewer.
* Add `article_renderer.js`: A shared script to render a Readability
article object into a document and runs post-processing.
* Add `distiller.js`: A content script to trigger the distillation
process on the active tab.
* Add `utils.js`: A new shared script with helper functions
(`consumeIdFromUrl()`, `consumeDataFromChromeStorage()`) to handle the
data-passing mechanism from the background script to extension pages.
* Update `popup.js`: Adds "Distill" and "Distill New" buttons to the UI
for both original and cloned pages.
* Update `background.js`: Handles the `distill` and `distill-new`
commands and refactors tab-handling logic.
* Update `cloned.js` / `cloned.html`: Integrates the distillation
feature and is refactored to use `utils.js`.
* Update `manifest.json`: Makes all new scripts, pages, and CSS files
web accessible.
* Update `README.md` and `.gitignore`: Documents the new features and
setup steps, and ignores all newly required symlinked files.
Bug: 449799192
Change-Id: I68d5169ddc80dd3aa55a46beee0f9991c47714c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033172
Reviewed-by: Brandon Wylie <wylieb@google.com>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528407}
[MediaCodecUtil] Convert some const char to constexpr
Misc cleanup.
R=philyan
Change-Id: Ifeca7c0b3cc3b72590842e5c720ff04dd0ce57b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030018
Reviewed-by: Phil Yan <philyan@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Phil Yan <philyan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528406}
Roll ios_internal from af8cbcd158c6 to 6e55f1ff2d9a
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/af8cbcd158c6..6e55f1ff2d9a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC cheickcisse@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ib5d1f5ddb562be9a48b396cd603e21e3f66b46d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032515
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528405}
[PWA/AppUpdating]: Apply pending updates to web app
This CL applies the pending update info to the web app. A previous CL
handled copying the icon bitmaps to their corresponding directories.
Updates to the name or icons (or both) are written to the web app. There
is also OS synchronization that happens afterwards.
Tests added to verify this behaviour.
Bug: 444497489
Change-Id: Id82109a3d4b5664d206ddaa0ff9aada1d09e3a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006759
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: May Siem <msiem@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528404}
[AIM] Fix query submission consistency
Addresses gaps in the original fix crrev.com/c/7007961, which wouldn't
reset handshake state, causing on the first query to be held. This CL
now resets the handshake anytime the page loads and when Lens is
dismissed.
Additionally, adds a new metric track query submissions vs query issued.
Submits tracks when the user actually presses submit, where as issued is
the moment the query is passed to the remote UI.
Bug: b:449016999
Change-Id: I4a59efe420e1c0cb8ef534dcc2b46580c69ee311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032289
Commit-Queue: Duncan Mercer <mercerd@google.com>
Reviewed-by: Juan Mojica <juanmojica@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528403}
Use new DBus types in components/dbus/xdg
R=thestig
Bug: None
Change-Id: I811f712b34e43a93bdc199d6bdab1fc8afb008cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032809
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528402}
Expose the AIM Sever Eligibility feature flag on Android.
This change simply makes the AIM Server Eligibility flag show on
Android.
Change-Id: Ibc6dad17421ac972c22a45722d057e270f0265f8
Fixed: 441692906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7031695
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528401}
Fix Wasm toolchain compiler path on Windows
On Windows CMD, a path starting with "../" is not a valid executable:
>../../third_party/emsdk/upstream/emscripten/em++.bat --version
'..' is not recognized as an internal or external command,
operable program or batch file.
Change the rebase_path invocations so they will use "system-absolute
native style paths with system path separators", e.g.:
>C:/src/dawn/third_party/emsdk/upstream/emscripten/em++.bat
Fixes building Dawn's Wasm GN targets on Windows, tested locally.
Bug: 450675299
Change-Id: Ieae38d4cdb3d96f4f60599b55e7f593c9247d354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032591
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Cr-Commit-Position: refs/heads/main@{#1528400}
[Task Icon] Add controller for Glic-related nudges
This controller will control the updated task list (formerly the "task
icon") nudges and eventually Gemini nudges.
Bug: 431015299
Change-Id: I167f1dc9f677f401b4adaa07e1cf135f66f5cb64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7017149
Reviewed-by: Darryl James <dljames@chromium.org>
Auto-Submit: Maggie Jennings <mjenn@google.com>
Commit-Queue: Maggie Jennings <mjenn@google.com>
Cr-Commit-Position: refs/heads/main@{#1528399}
WaaP: fix reload button includes for Android
We don't need the reload button UI for Android but it's still included,
this will cause trouble when the file is referenced later from browser
ui.
Bug: 444358999
Change-Id: I0941ab488aa0869b023f84a23a0f7be226228628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7025691
Reviewed-by: Teresa Mao <temao@chromium.org>
Commit-Queue: Teresa Mao <temao@chromium.org>
Auto-Submit: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528398}
Roll WebView ARM64 Orderfile from GPyj4-Tlz83SXy_Hi... to 1AxlJSkzS2TgGl2V6...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-webview-arm64-chromium
Please CC woa-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I24e4170f6f00008ca85763d97b70872182badcb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7033257
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528397}
[SidePanel] Move pinning logic out of SidePanelCoordinator
Currently the pinning logic is in the SidePanelCoordinator and should
be moved to a dedicated class that handles pinning because it is only
relevant for the side panel header.
Bug: 450649530
Change-Id: I4da6ff24bbc2e076efdaf26d8377683865e63482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7029539
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528396}
Rename local variables with camel case in AwContents.java
These variables were causing presubmit warnings.
Change-Id: I2cf84f0e80b21e3ea3ea030242eb1ccc189b1805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7030684
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Alex Mitra <alexmitra@chromium.org>
Commit-Queue: Alex Mitra <alexmitra@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528395}