| CARVIEW |
Select Language
HTTP/2 200
accept-ranges: bytes
content-type: text/html; charset=UTF-8
set-cookie: Bugzilla_login_request_cookie=XxNBh5KLcv1L; path=/; secure; HttpOnly; SameSite=Lax
set-cookie: github_token=wW0OsSqcrghMD5E2wecTaEsIj6Rp7d5p66Sf8B1RGGin1rrrO33oqASor8N8pe1iVOwnswJDZ65eP2LKq52UfSZGOeZW16fvHVQ7Vb9HmY1t4zmYqJTBk1GI2er5KCnwUUc3fg9tNkeUC9lc1BfGzr4oYs9qNUHJznIfT0RUwZ9iJf5IW7sowL2AioDeAl1RZV30o54LYx0CVrBjvCs1liS1op4sMbFsLELSd6IzT5sIfRmpjNlYxNJ1ne5G31HK; path=/; secure; HttpOnly; SameSite=Lax
via: 1.1 google, 1.1 varnish, 1.1 varnish
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
strict-transport-security: max-age=31536000; includeSubDomains
content-encoding: gzip
referrer-policy: same-origin
server: nginx
x-frame-options: SAMEORIGIN
content-security-policy: default-src 'self'; worker-src 'none'; connect-src 'self' https://product-details.mozilla.org https://treeherder.mozilla.org/api/failurecount/; font-src 'self' https://fonts.gstatic.com; img-src 'self' data: https://secure.gravatar.com https://bug1977903.bmoattachments.org/; media-src 'self' https://bug1977903.bmoattachments.org/; object-src 'none'; script-src 'self' 'nonce-Birs90PE68QIbKVpE71zmebUexlHEtb7bgNV6aToOWljupQl' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'; frame-src 'self' https://crash-stop-addon.herokuapp.com; frame-ancestors 'self'; form-action 'self' https://www.google.com/search https://github.com/login/oauth/authorize https://github.com/login https://phabricator.services.mozilla.com/ https://people.mozilla.org
date: Sun, 05 Oct 2025 01:24:41 GMT
x-served-by: cache-bom-vanm7210045-BOM, cache-bom-vanm7210045-BOM
x-cache: MISS, MISS
x-cache-hits: 0, 0
x-timer: S1759627480.349671,VS0,VE1221
vary: Accept-Encoding
1977903 - Remove comment in the updated() function
Closed
Bug 1977903
Opened 3 months ago
Closed 2 months ago
Remove comment in the updated() function
*
Summary:
Remove comment in the updated() function
Categories
(Toolkit :: UI Widgets, task, P3)
Tracking
()
RESOLVED
FIXED
RESOLVED
FIXED
143 Branch
Iteration:
---
| Webcompat Score | |
| a11y-review | |
| Performance Impact | |
| Accessibility Severity | |
| Webcompat Priority |
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
| Tracking | Status | |
|---|---|---|
| relnote-firefox | ||
| thunderbird_esr115 | ||
| thunderbird_esr140 | ||
| firefox-esr115 | ||
| firefox-esr140 | ||
| firefox143 | ||
| firefox144 | ||
| firefox145 |
People
(Reporter: tgiles, Assigned: balrajdhawan600, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [recomp] [lang=js])
---
[recomp] [lang=js]
QA Whiteboard:
[qa-triage-done-c144/b143]
Has STR:
---
Change Request:
---
0
Bug Flags:
|
| ||||
Crash Data
Signature:
None
Security
(public)
This bug is publicly visible.
User Story
Attachments
(1 file)
There's an unneeded comment in the updated function in moz-promo.
Acceptance Criteria:
- The comment in the updated function in moz-promo is removed
- No other changes are made
|
||
Updated•3 months ago
|
|
Assignee | |
Comment 1•3 months ago
|
||
Hi Tim, Can I work on this? Can you confirm the reviewer I should use?
|
Reporter | |
Comment 2•3 months ago
•
|
||
Hey Balraj, feel free to work on this! Here's some more information to help you get started with the process!
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help.
This will tell others that you're working on the next steps. - Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introductionchannel. They're there to help you get started.
- If you have any problems, please ask on Element/Matrix in the
- Start working on this bug. You'll need to remove the comment in the updated function in moz-promo
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me by using the "Request information from" checkbox and setting the dropdown select to "mentor". Also, you can find me and my teammates on the
#reusable-componentschannel on Element/Matrix most hours of most days.
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me by using the "Request information from" checkbox and setting the dropdown select to "mentor". Also, you can find me and my teammates on the
- Build your change with
./mach buildand test your change with./mach test toolkit/content/tests/widgets/test_moz_promo.html --headless. Also check your changes for adherence to our style guidelines by using./mach lint. - Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- How to Submit a Patch
- This is when the bug will be assigned to you.
- After a series of reviews and changes to your patch, I'll push it to autoland.
- If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
- Your code will soon be shipping to Firefox users worldwide!
Flags: needinfo?(balrajdhawan600)
|
|
Assignee | |
Comment 3•3 months ago
|
||
|
||
Updated•3 months ago
|
Assignee: nobody → balrajdhawan600
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•3 months ago
|
||
Hi Tim,
I worked on it and submitted a patch for it as well.
Thanks for the detailed steps and guidance — I really appreciate it!
Best,
Balraj
Flags: needinfo?(balrajdhawan600)
Pushed by tgiles@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/dee954f1b199
https://hg.mozilla.org/integration/autoland/rev/a3fbfb632f43
Remove comment from updated() function. r=tgiles,reusable-components-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
|
||
Updated•2 months ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•