HTTP/2 200 x-amz-id-2: gbl5ZeutwRTh9hqewAHV6o3R+gIqydqwV3EoKbOg8G3RlIl/t7rk6wFQ7kdtD/JK1LSJjwh+694= x-amz-request-id: BD14ZTHA8EJS8F28 last-modified: Fri, 02 Dec 2022 04:00:18 GMT etag: "21de40b0d0f6126cd1c6e0811c310556" server: AmazonS3 content-encoding: gzip via: 1.1 varnish, 1.1 varnish content-type: text/plain; charset=utf-8 accept-ranges: bytes age: 0 date: Fri, 18 Jul 2025 08:27:28 GMT x-served-by: cache-tyo11937-TYO, cache-bom4727-BOM x-cache: HIT, MISS x-cache-hits: 1, 0 x-timer: S1752827248.006637,VS0,VE575 vary: Accept-Encoding content-length: 882 From: Yukihiro Matsumoto Date: 2009-08-26T22:06:22+09:00 Subject: [ruby-core:25139] Patch writer's guide to submit Hi, Sometimes we laze core developers have procrastinated to review submitted patches, been late to merge patchs, and frustrated submitters. That's unfortunate for both side. Here's the guideline to avoid such miscommunication. * one modification per a patch This is the biggest issue for most deferred patches. When you submit a patch that fix multiple bugs (and add features) at once, we have to separate them before applying it. It is kinda hard task for us, busy developers, so this kind of patches tend to be deferred. No big patches please. * more description Sometimes mere patches do not describe problems that fix. Better description (a problem that fix, precondition, platform, etc.) would help a patch to be merged earlier. * diff to the latest Your problem might have been fixed in the latest. Or the code might be totally different. Before submitting a patch, try fetch the latest (trunk for 1.9, ruby_1_8 for 1.8) from Subversion, please. * diff -u We perefer diff -u style unified diff patches to diff -c or any other style of patches. They are far easier to review. Do not send modifed files, we don't want to make diff by ourselves. * (optional) test cases a patch to test cases (preferably in a patch to test/*/test_*.rb) would help us understand the patch and your intention. We might move to git style push/pull in the future. But until then, the above guideline would help you to avoid your frustration. Thank you. matz.