| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 16 Jan 2026 17:42:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=382.14631,conversation_content-fragment;desc="conversation_content fragment";dur=513.542421,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=272.517792,nginx;desc="NGINX";dur=0.85305,glb;desc="GLB";dur=106.054036
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 69ef6d1
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=B4iH%2BB3Ql1ef%2BiRqy5QZ7O%2BMvtBjWZae31hG4Owus91fuEM7ARCrJpkgpeuV%2FIp6vHAVywA5GG41OLoLUulkHzs2copUHMfGnIPWZDFOxnbtnte0FzRsQ6BQCRO7BY7O9CwSQIt9hI4D4bCo5K2TbgCrRivApm%2BVz2CJPuZGaTRX6Ra25Co4ihAN%2BjmiZKr5tKAGqQYs%2Flr9a4o6NDcIHhp5xgN%2BQl7iN8tfhuDhMcstUdI8vb%2FlQ0fNdGfZl8xbdrYOzdZAUGjGXQwFB1GTJw%3D%3D--MS23gfw%2BuhayUmeG--jDN4PG2Lq0yqFllAeyIrjg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1419407306.1768585321; Path=/; Domain=github.com; Expires=Sat, 16 Jan 2027 17:42:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 16 Jan 2027 17:42:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CD72:38CC4D:8AE8E9:9A475D:696A7869
Use level-wise algorithm for BF unfolds by treeowl · Pull Request #198 · haskell/containers · GitHub
Copy link
treeowl
force-pushed
the
level-wise-unfoldM
branch
from
April 22, 2016 01:38
Copy link
treeowl
force-pushed
the
level-wise-unfoldM
branch
2 times, most recently
from
April 22, 2016 01:56
treeowl
force-pushed
the
level-wise-unfoldM
branch
from
April 22, 2016 02:14
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 186
Use level-wise algorithm for BF unfolds #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
treeowl
wants to merge
1
commit into
haskell:master
Choose a base branch
from
treeowl:level-wise-unfoldM
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This addresses #124 |
de68844 to
72bfa89
Compare
Contributor
Author
|
@wrengr, I could use a sanity check on this. Also, we really need to come up with QuickCheck properties for this module; currently, we basically have no specification to implement. |
b043446 to
674a610
Compare
`unfoldTreeM_BF` and `unfoldForestM_BF` previously used a queue-based algorithm from a note by Okasaki. That same note indicates that the level-wise approach tends to be slightly faster, and my own informal tests suggest the same. Both solutions suffer from a potential space leak, retaining the seed lists longer than necessary in order to later use their lengths. It remains to be seen whether this leak can be plugged without a speed penalty.
674a610 to
e12fda7
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
unfoldTreeM_BFandunfoldForestM_BFpreviously used aqueue-based algorithm from a note by Okasaki. That same
note indicates that the level-wise approach tends to be slightly
faster, and my own informal tests suggest the same. Both solutions
suffer from a potential space leak, retaining the seed lists
longer than necessary in order to later use their lengths. It
remains to be seen whether this leak can be plugged without
a speed penalty.