fix: When closing socket destroy() instead of end() it (#967)

zobo · zobo · commit 9043033f95e8 · 2024-07-15T23:20:19.000+02:00
diff --git a/src/cloud.ts b/src/cloud.ts
@@ -225,4 +225,12 @@ class InnerCloudTransport extends EventEmitter implements Transport {
         }
         return this
     }
+
+    destroy(error?: Error): this {
+        if (this._open) {
+            this._open = false
+            this.emit('close')
+        }
+        return this
+    }
 }
diff --git a/src/dbgp.ts b/src/dbgp.ts
@@ -18,6 +18,7 @@ export interface Transport {
     on(event: 'close', listener: () => void): this
     write(buffer: Uint8Array | string, cb?: (err?: Error) => void): boolean
     end(callback?: () => void): this
+    destroy(error?: Error): this
 }
 
 export declare interface DbgpConnection {
@@ -145,7 +146,7 @@ export class DbgpConnection extends EventEmitter {
 
     /** closes the underlying socket */
     public close(): Promise<void> {
-        this._socket.end()
+        this._socket.destroy()
         return this._closePromise
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -225,4 +225,12 @@ class InnerCloudTransport extends EventEmitter implements Transport {`
`225`	`225`	`}`
`226`	`226`	`return this`
`227`	`227`	`}`
	`228`	`+`
	`229`	`+ destroy(error?: Error): this {`
	`230`	`+ if (this._open) {`
	`231`	`+ this._open = false`
	`232`	`+ this.emit('close')`
	`233`	`+ }`
	`234`	`+ return this`
	`235`	`+ }`
`228`	`236`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ export interface Transport {`
`18`	`18`	`on(event: 'close', listener: () => void): this`
`19`	`19`	`write(buffer: Uint8Array \| string, cb?: (err?: Error) => void): boolean`
`20`	`20`	`end(callback?: () => void): this`
	`21`	`+ destroy(error?: Error): this`
`21`	`22`	`}`
`22`	`23`
`23`	`24`	`export declare interface DbgpConnection {`
`@@ -145,7 +146,7 @@ export class DbgpConnection extends EventEmitter {`
`145`	`146`
`146`	`147`	`/** closes the underlying socket */`
`147`	`148`	`public close(): Promise<void> {`
`148`		`- this._socket.end()`
	`149`	`+ this._socket.destroy()`
`149`	`150`	`return this._closePromise`
`150`	`151`	`}`
`151`	`152`	`}`