CARVIEW |
Select Language
HTTP/2 301
date: Sun, 27 Jul 2025 09:15:18 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2140
server-timing: nginx;desc="NGINX";dur=0.688541,glb;desc="GLB";dur=102.851527
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=Y1Xwv01twAXek1V9P5UYw2e5yESPWdUYLwoXsedgG2bs3Mg9H8k2KUruSyKUHKtHScVuT5jxrdb8lzuX%2Fy7a4v037BO5ZPKY69%2BB6AdPJEo7M7DL%2Ff1H7RQYwz8siC0fVJoRCeURMThhk0QqPFsWJgMMdc9%2B8MWG9W8JsrbYoOVI2VBEv7Fio1XJKboHpLoVbHezVqhJ8xHfN9MptDjhIoWhtUhpko%2FzXy92tF9lZRC73%2F3rN34%2F%2FkJqIn5%2Bi5sYShMmT%2BVcvNgbOayHFtjHsQ%3D%3D--xFz5uw%2B4iD4T%2Fp2E--O3LcmvZMovoq7IxqaG9YNw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1825564952.1753607718; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 09:15:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 09:15:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A420:3ED739:C9AC17:10B66E5:6885EE26
HTTP/2 200
date: Sun, 27 Jul 2025 09:15:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=344.493967,conversation_content-fragment;desc="conversation_content fragment";dur=590.078669,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=300.831286,nginx;desc="NGINX";dur=1.039058,glb;desc="GLB";dur=101.680107
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: A420:3ED739:C9AC36:10B670C:6885EE26
[Xamarin.Android.Build.Tasks] leave classes.zip uncompressed by jonathanpeppers · Pull Request #2140 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] leave classes.zip uncompressed #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:classes.zip-uncompressed
Sep 5, 2018
Merged
[Xamarin.Android.Build.Tasks] leave classes.zip uncompressed #2140
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:classes.zip-uncompressed
Sep 5, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking about a couple of the slower MSBuild tasks: - `Javac` - `CompileToDalvik` One thing I noticed here was that `Javac` outputs a `classes.zip` file, and `CompileToDalvik` consumes it. It also looked like we are using `CompressionMethod.Default` as you would expect. So why should we compress this file at all? It seemed that was work we could just skip and things would work fine? Presumably `dx.jar` can work with an uncompressed `classes.zip` file faster than a compressed one? So I made the following changes: - Added an option to pass in the `CompressionMethod` in `ZipArchiveEx` - Used `CompressionMethod.Store` for creating `classes.zip` The results on a File | New Xamarin.Forms app looked great! Before: 3443 ms Javac 1 calls 11545 ms CompileToDalvik 1 calls After: 3338 ms Javac 1 calls 10535 ms CompileToDalvik 1 calls I did a `Clean` before running the `SignAndroidPackage` target on these builds. These savings seem pretty good! The only drawback being we use more disk space in `$(IntermediateOutputPath)`.
Build logs here: ClassesZipUncompressed.zip |
dellis1972
approved these changes
Sep 5, 2018
jonpryor
pushed a commit
that referenced
this pull request
Sep 5, 2018
I was thinking about a couple of the slower MSBuild tasks: - `Javac` - `CompileToDalvik` One thing I noticed here was that `Javac` outputs a `classes.zip` file, and `CompileToDalvik` consumes it. It also looked like we are using `CompressionMethod.Default` as you would expect. So why should we compress this file at all? It seemed that was work we could just skip and things would work fine? Presumably `dx.jar` can work with an uncompressed `classes.zip` file faster than a compressed one? So I made the following changes: - Added an option to pass in the `CompressionMethod` in `ZipArchiveEx` - Used `CompressionMethod.Store` for creating `classes.zip` The results on a File | New Xamarin.Forms app looked great! Before: 3443 ms Javac 1 calls 11545 ms CompileToDalvik 1 calls After: 3338 ms Javac 1 calls 10535 ms CompileToDalvik 1 calls I did a `Clean` before running the `SignAndroidPackage` target on these builds. These savings seem pretty good! The only drawback being we use more disk space in `$(IntermediateOutputPath)`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
I was thinking about a couple of the slower MSBuild tasks:
Javac
CompileToDalvik
One thing I noticed here was that
Javac
outputs aclasses.zip
file, and
CompileToDalvik
consumes it. It also looked like we areusing
CompressionMethod.Default
as you would expect.So why should we compress this file at all? It seemed that was work we
could just skip and things would work fine? Presumably
dx.jar
canwork with an uncompressed
classes.zip
file faster than a compressedone?
So I made the following changes:
CompressionMethod
inZipArchiveEx
CompressionMethod.Store
for creatingclasses.zip
The results on a File | New Xamarin.Forms app looked great!
Before:
After:
I did a
Clean
before running theSignAndroidPackage
target onthese builds.
These savings seem pretty good! The only drawback being we use more
disk space in
$(IntermediateOutputPath)
.