Also fix archiving a site by numeric slug (#448)

danielbachhuber · web-flow · commit ce37f3c04562 · 2023-11-16T05:25:22.000-08:00
diff --git a/features/site.feature b/features/site.feature
@@ -139,7 +139,33 @@ Feature: Manage sites in a multisite installation
     When I try the previous command again
     Then STDERR should contain:
       """
-      Site with slug '42' does not exist.
+      Error: Could not find site with slug '42'.
+      """
+    And the return code should be 1
+
+  Scenario: Archive a site by a numeric slug
+    Given a WP multisite install
+
+    When I run `wp site create --slug=42`
+    Then STDOUT should contain:
+      """
+      Success: Site 2 created: http
+      """
+    And STDOUT should contain:
+      """
+      ://example.com/42/
+      """
+
+    When I run `wp site archive --slug=42`
+    Then STDOUT should contain:
+      """
+      Success: Site 2 archived.
+      """
+
+    When I try `wp site archive --slug=43`
+    Then STDERR should contain:
+      """
+      Error: Could not find site with slug '43'.
       """
     And the return code should be 1
 
diff --git a/src/Site_Command.php b/src/Site_Command.php
@@ -334,7 +334,7 @@ public function delete( $args, $assoc_args ) {
 		if ( isset( $assoc_args['slug'] ) ) {
 			$blog_id = get_id_from_blogname( $assoc_args['slug'] );
 			if ( null === $blog_id ) {
-				WP_CLI::error( "Site with slug '{$assoc_args['slug']}' does not exist." );
+				WP_CLI::error( sprintf( 'Could not find site with slug \'%s\'.', $assoc_args['slug'] ) );
 			}
 			$blog = get_blog_details( $blog_id );
 		} else {
@@ -982,11 +982,11 @@ private function get_sites_ids( $args, $assoc_args ) {
 		$slug = Utils\get_flag_value( $assoc_args, 'slug', false );
 
 		if ( $slug ) {
-			$blog = get_blog_details( trim( $slug, '/' ) );
-			if ( ! $blog ) {
+			$blog_id = get_id_from_blogname( trim( $slug, '/' ) );
+			if ( null === $blog_id ) {
 				WP_CLI::error( sprintf( 'Could not find site with slug \'%s\'.', $slug ) );
 			}
-			return [ $blog->blog_id ];
+			return [ $blog_id ];
 		}
 
 		return $args;
