You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses feedback in Issue #455, to link navigation behavior to the HTML 5.1 navigation steps, and clarify how the receiving user agent should respond.
There's also a bunch of changes from attempting to run tidy-html5 which I'll clean up in another commit on this PR.
The reason will be displayed to describe this comment to others. Learn more.
That is not entirely "consistent" with the steps to navigate: the steps to navigate in HTML mandate the SecurityError be thrown when the exceptions enabled flag is set, whereas this makes it optional.
If the SecurityError exception cannot be mandated because it remains a challenge implementation-wise, I would suggest to drop "(consistent with the steps to navigate)".
The reason will be displayed to describe this comment to others. Learn more.
Throwing the exception isn't an implementation concern from my point of view. Rather I didn't want to get into the details here of when to throw a SecurityError and thus duplicate HTML. I rephrased this, let me know if that addresses your feedback.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses feedback in Issue #455, to link navigation behavior to the HTML 5.1 navigation steps, and clarify how the receiving user agent should respond.
There's also a bunch of changes from attempting to run tidy-html5 which I'll clean up in another commit on this PR.
Preview | Diff