You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat these tables separately so we can be more clear with guidance specific to roles vs attributes.
adds in new specific attribute call outs on elements such as checkbox, radio, options and selects which should not have specific aria-* attributes set.
revised/re-explained allowances for specific html attributes and their implicit aria attribute semantics are in the new second table.
@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.
@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.
ok makes sense. i opened a separate issue to track this. so with that out of the way, i think this is good to go
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat these tables separately so we can be more clear with guidance specific to roles vs attributes.
adds in new specific attribute call outs on elements such as checkbox, radio, options and selects which should not have specific aria-* attributes set.
revised/re-explained allowances for specific html attributes and their implicit aria attribute semantics are in the new second table.
This PR will close #122, #225 and #241
Preview | Diff