Jackson2: Super class did not get type information #497

michaelzangl · 2020-06-29T12:03:01Z

Jackson can (de)serialize instances of the hierarchy root class when using @JsonSubTypes. When generating interface for this java class:

    @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "type")
    @JsonSubTypes(@JsonSubTypes.Type(NonAbstractRootSub.class))
    @JsonTypeName("rootType")
    public static class NonAbstractRoot {
    }
    @JsonTypeName("subType")
    public static class NonAbstractRootSub extends NonAbstractRoot {
    }

Previously wrong generated code ("rootType" missing):

interface NonAbstractRoot {
    type: "subType";
}
interface NonAbstractRootSub extends NonAbstractRoot {
    type: "subType";
}
type NonAbstractRootUnion = NonAbstractRootSub;

Correct:

interface NonAbstractRoot {
    type: "rootType" | "subType";
}
interface NonAbstractRootSub extends NonAbstractRoot {
    type: "subType";
}
type NonAbstractRootUnion = NonAbstractRootSub;

…ey are not abstract.

vojtechhabarta · 2020-07-07T07:03:14Z

Thanks for your pull request with good example.

While this fixes typescript-generator inconsistency with Jackson it can break some users code. I am not sure how frequent this problem could be but I think we need to change this sooner the better.

For users:

make root class abstract if you don't want discriminant value for this class to be included in union

vojtechhabarta · 2020-08-05T08:27:04Z

Released in v2.25.695.

michaelzangl added 2 commits June 29, 2020 13:59

Jackson2: Classes with type info annotation can be used as type if th…

eb5ad7a

…ey are not abstract.

Mark test classes that should not be deserializable as abstract.

dcba663

michaelzangl force-pushed the fix-polymorphic-root-type-name branch from 688010a to dcba663 Compare June 29, 2020 13:45

vojtechhabarta merged commit 8e91cd7 into vojtechhabarta:master Jul 7, 2020

vojtechhabarta added this to the 2.25 milestone Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jackson2: Super class did not get type information #497

Jackson2: Super class did not get type information #497

Uh oh!

michaelzangl commented Jun 29, 2020 •

edited

Loading

Uh oh!

vojtechhabarta commented Jul 7, 2020

Uh oh!

vojtechhabarta commented Aug 5, 2020

Uh oh!

Uh oh!

Jackson2: Super class did not get type information #497

Jackson2: Super class did not get type information #497

Uh oh!

Conversation

michaelzangl commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vojtechhabarta commented Jul 7, 2020

Uh oh!

vojtechhabarta commented Aug 5, 2020

Uh oh!

Uh oh!

michaelzangl commented Jun 29, 2020 •

edited

Loading