fix: Ensure native segment metadata track has mode hidden (#1550)

mister-ben · dzianis-dashkevich · web-flow · commit c1d31867b913 · 2025-02-04T23:51:06.000-05:00
Co-authored-by: Dzianis Dashkevich &lt;98566601+dzianis-dashkevich@users.noreply.github.com&gt;
diff --git a/index.html b/index.html
@@ -192,6 +192,11 @@
           <label class="form-check-label" for="forced-subtitles">Use Forced Subtitles (reloads player)</label>
         </div>
 
+        <div class="form-check">
+          <input id="native-text-tracks" type="checkbox" class="form-check-input">
+          <label class="form-check-label" for="native-text-tracks">Use native text tracks (reloads player)</label>
+        </div>
+
         <div class="input-group">
           <span class="input-group-text"><label for=preload>Preload (reloads player)</label></span>
           <select id=preload class="form-select">
diff --git a/scripts/index.js b/scripts/index.js
@@ -474,7 +474,8 @@
     'use-mms',
     'preload',
     'mirror-source',
-    'forced-subtitles'
+    'forced-subtitles',
+    'native-text-tracks'
   ].forEach(function(name) {
     stateEls[name] = document.getElementById(name);
   });
@@ -528,7 +529,8 @@
       'network-info',
       'dts-offset',
       'exact-manifest-timings',
-      'forced-subtitles'
+      'forced-subtitles',
+      'native-text-tracks'
     ].forEach(function(name) {
       stateEls[name].addEventListener('change', function(event) {
         saveState();
@@ -603,6 +605,7 @@
           liveui: stateEls.liveui.checked,
           enableSourceset: mirrorSource,
           html5: {
+            nativeTextTracks: getInputValue(stateEls['native-text-tracks']),
             vhs: {
               overrideNative: getInputValue(stateEls['override-native']),
               experimentalUseMMS: getInputValue(stateEls['use-mms']),
diff --git a/src/playlist-controller.js b/src/playlist-controller.js
@@ -254,6 +254,8 @@ export class PlaylistController extends videojs.EventTarget {
       label: 'segment-metadata'
     }, false).track;
 
+    this.segmentMetadataTrack_.mode = 'hidden';
+
     this.decrypter_ = new Decrypter();
     this.sourceUpdater_ = new SourceUpdater(this.mediaSource);
     this.inbandTextTracks_ = {};
diff --git a/test/playlist-controller.test.js b/test/playlist-controller.test.js
@@ -7787,3 +7787,23 @@ QUnit.test('ManagedMediaSource startstreaming and endstreaming events start and
 
   mms.restore();
 });
+
+QUnit.module('Native tracks', {
+  beforeEach(assert) {
+    this.playerOptions = {
+      html5: {
+        nativeTextTracks: true
+      }
+    };
+    sharedHooks.beforeEach.call(this, assert);
+    this.pc = this.playlistController;
+
+  },
+  afterEach(assert) {
+    sharedHooks.afterEach.call(this, assert);
+  }
+});
+
+QUnit.test('Native text track mode is hidden', function(assert) {
+  assert.strictEqual(this.pc.segmentMetadataTrack_.mode, 'hidden', 'track mode is hidden');
+});
