fix: enable nocomment glob option for rule no-unassigned-import's allow option (#352)

JounQin · web-flow · commit 3bc48fcfab4b · 2025-05-27T08:44:59.000+08:00
diff --git a/.changeset/wise-tables-stop.md b/.changeset/wise-tables-stop.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix: enable `nocomment` glob option for rule `no-unassigned-import`'s `allow` option
diff --git a/src/rules/no-unassigned-import.ts b/src/rules/no-unassigned-import.ts
@@ -21,8 +21,11 @@ function testIsAllow(
 
   return globs.some(
     glob =>
-      minimatch(filePath, glob) ||
-      minimatch(filePath, path.resolve(glob), { windowsPathsNoEscape: true }),
+      minimatch(filePath, glob, { nocomment: true }) ||
+      minimatch(filePath, path.resolve(glob), {
+        nocomment: true,
+        windowsPathsNoEscape: true,
+      }),
   )
 }
 
diff --git a/test/rules/no-unassigned-import.spec.ts b/test/rules/no-unassigned-import.spec.ts
@@ -73,6 +73,20 @@ ruleTester.run('no-unassigned-import', rule, {
       filename: path.resolve('src/app.js'),
       options: [{ allow: ['src/styles/**', '**/scripts/*.js'] }],
     }),
+    tValid({
+      code: 'import "#app/side-effects.js"',
+      // exactly matched
+      options: [{ allow: ['#app/side-effects.js'] }],
+    }),
+    tValid({
+      code: 'import "#app/side-effects.js"',
+      /**
+       * Matched by glob
+       *
+       * @see https://github.com/isaacs/minimatch#comparisons-to-other-fnmatchglob-implementations
+       */
+      options: [{ allow: [String.raw`\#app/side-effects.js`] }],
+    }),
   ],
   invalid: [
     tInvalid({

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"eslint-plugin-import-x": patch
 +---
++
 +fix: enable `nocomment` glob option for rule `no-unassigned-import`'s `allow` option
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,11 @@ function testIsAllow(`
`21`	`21`
`22`	`22`	`return globs.some(`
`23`	`23`	`glob =>`
`24`		`- minimatch(filePath, glob) \|\|`
`25`		`- minimatch(filePath, path.resolve(glob), { windowsPathsNoEscape: true }),`
	`24`	`+ minimatch(filePath, glob, { nocomment: true }) \|\|`
	`25`	`+ minimatch(filePath, path.resolve(glob), {`
	`26`	`+ nocomment: true,`
	`27`	`+ windowsPathsNoEscape: true,`
	`28`	`+ }),`
`26`	`29`	`)`
`27`	`30`	`}`
`28`	`31`