refactor: rollback Collapse

wxsms · wxsms · commit 8833c83731c1 · 2021-11-21T18:09:25.000+08:00
diff --git a/src/components/collapse/Collapse.vue b/src/components/collapse/Collapse.vue
@@ -1,80 +1,85 @@
-<script lang="jsx" setup>
+<script lang="jsx">
 import { addClass, removeClass } from '../../utils/dom.utils';
-import { onMounted, ref, watchEffect } from 'vue';
-
-const props = defineProps({
-  tag: { type: String, default: 'div' },
-  modelValue: { type: Boolean, default: false },
-  transition: { type: Number, default: 350 },
-});
-const emit = defineEmits(['show', 'shown', 'hide', 'hidden']);
 
 const COLLAPSE = 'collapse';
 const IN = 'in';
 const COLLAPSING = 'collapsing';
-let timeoutId = 0;
-const element = ref(null);
 
-function toggle(show) {
-  clearTimeout(timeoutId);
-  const el = element.value;
-  if (!el) {
-    return;
-  }
-  if (show) {
-    emit('show');
-    removeClass(el, COLLAPSE);
-    el.style.height = 'auto';
-    const height = window.getComputedStyle(el).height;
-    el.style.height = null;
-    addClass(el, COLLAPSING);
-    el.offsetHeight; // force repaint
-    el.style.height = height;
-    timeoutId = setTimeout(() => {
-      removeClass(el, COLLAPSING);
-      addClass(el, COLLAPSE);
+export default {
+  props: {
+    tag: {
+      type: String,
+      default: 'div',
+    },
+    modelValue: {
+      type: Boolean,
+      default: false,
+    },
+    transition: {
+      type: Number,
+      default: 350,
+    },
+  },
+  emits: ['show', 'shown', 'hide', 'hidden'],
+  data() {
+    return {
+      timeoutId: 0,
+    };
+  },
+  watch: {
+    modelValue(show) {
+      this.toggle(show);
+    },
+  },
+  mounted() {
+    const el = this.$el;
+    addClass(el, COLLAPSE);
+    if (this.modelValue) {
       addClass(el, IN);
-      el.style.height = null;
-      timeoutId = 0;
-      emit('shown');
-    }, props.transition);
-  } else {
-    emit('hide');
-    el.style.height = window.getComputedStyle(el).height;
-    removeClass(el, IN);
-    removeClass(el, COLLAPSE);
-    el.offsetHeight;
-    el.style.height = null;
-    addClass(el, COLLAPSING);
-    timeoutId = setTimeout(() => {
-      addClass(el, COLLAPSE);
-      removeClass(el, COLLAPSING);
-      el.style.height = null;
-      timeoutId = 0;
-      emit('hidden');
-    }, props.transition);
-  }
-}
-
-watchEffect(() => {
-  toggle(props.modelValue);
-});
-
-onMounted(() => {
-  addClass(element.value, COLLAPSE);
-  if (props.modelValue) {
-    addClass(element.value, IN);
-  }
-});
-</script>
-
-<script lang="jsx">
-import { defineComponent } from 'vue';
-
-export default defineComponent({
+    }
+  },
+  methods: {
+    toggle(show) {
+      clearTimeout(this.timeoutId);
+      const el = this.$el;
+      if (show) {
+        this.$emit('show');
+        removeClass(el, COLLAPSE);
+        el.style.height = 'auto';
+        const height = window.getComputedStyle(el).height;
+        el.style.height = null;
+        addClass(el, COLLAPSING);
+        el.offsetHeight; // force repaint
+        el.style.height = height;
+        this.timeoutId = setTimeout(() => {
+          removeClass(el, COLLAPSING);
+          addClass(el, COLLAPSE);
+          addClass(el, IN);
+          el.style.height = null;
+          this.timeoutId = 0;
+          this.$emit('shown');
+        }, this.transition);
+      } else {
+        this.$emit('hide');
+        el.style.height = window.getComputedStyle(el).height;
+        removeClass(el, IN);
+        removeClass(el, COLLAPSE);
+        el.offsetHeight;
+        el.style.height = null;
+        addClass(el, COLLAPSING);
+        this.timeoutId = setTimeout(() => {
+          addClass(el, COLLAPSE);
+          removeClass(el, COLLAPSING);
+          el.style.height = null;
+          this.timeoutId = 0;
+          this.$emit('hidden');
+        }, this.transition);
+      }
+    },
+  },
   render() {
     const Tag = this.tag;
-    return <Tag ref="element">{this.$slots.default?.()}</Tag>;
+    return <Tag>{this.$slots.default?.()}</Tag>;
   },
-});
+};
 </script>
