feat: support allows

azu · azu · commit 0e496443352a · 2021-10-17T16:58:14.000+09:00
diff --git a/README.md b/README.md
@@ -47,6 +47,31 @@ Via CLI
 textlint --rule @textlint-rule/no-duplicate-abbr README.md
 ```
 
+## Options
+
+```ts
+export type Options = {
+    /**
+     * A list for ignoring Acronyms or Abbreviations.
+     * e.g. you can allow "NPO organization" by following setting.
+     * "allowAbbrList": ["NPO"]
+     */
+    allowAbbrList: string[];
+}
+```
+
+Example setting:
+
+```json5
+{
+  "rules": {
+    "@textlint-rule/no-duplicate-abbr": {
+      "allowAbbrList": ["NPO"] // Allow to use "NPO organization"
+    }
+  }
+}
+```
+
 ## Changelog
 
 See [Releases page](https://github.com/textlint-rule/textlint-rule-no-duplicate-abbr/releases).
diff --git a/src/textlint-rule-no-duplicate-abbr.ts b/src/textlint-rule-no-duplicate-abbr.ts
@@ -1,16 +1,29 @@
 import { TextlintRuleReporter } from "@textlint/types";
 import dataset from "./dataset.json";
 
-const reporter: TextlintRuleReporter = (context) => {
+export type Options = {
+    /**
+     * A list for ignoring Acronyms or Abbreviations.
+     * e.g. you can allow "NPO organization" by following setting.
+     * "allowAbbrList": ["NPO"]
+     */
+    allowAbbrList: string[];
+};
+const reporter: TextlintRuleReporter<Options> = (context, options) => {
     const { Syntax, getSource, report, RuleError } = context;
     const abbrDataSet = new Map<string, { suffixes: string[]; definition: string }>(
         dataset as [string, { suffixes: string[]; definition: string }][]
     );
+    const allowAbbrList = options?.allowAbbrList ?? [];
     return {
         [Syntax.Str](node) {
             const source = getSource(node);
             const words = source.split(/\b/);
             words.forEach((word, index) => {
+                // Skip the word
+                if (allowAbbrList.includes(word)) {
+                    return;
+                }
                 const hasSpace = /\s/.test(words[index + 1]);
                 const nextWord = hasSpace ? words[index + 2] : words[index + 1];
                 if (!nextWord) {
@@ -31,7 +44,7 @@ const reporter: TextlintRuleReporter = (context) => {
                     report(
                         node,
                         new RuleError(
-                            `"${word}${spacer}${nextWord}" uses duplicated suffix word. "${word}" stands for "${matchData.definition}".`,
+                            `"${word}${spacer}${nextWord}" has duplicated suffix word. "${word}" stands for "${matchData.definition}".`,
                             {
                                 index: startIndexOfWord
                             }
diff --git a/test/textlint-rule-no-duplicate-abbr.test.ts b/test/textlint-rule-no-duplicate-abbr.test.ts
@@ -1,14 +1,24 @@
 import TextLintTester from "textlint-tester";
 import rule from "../src/textlint-rule-no-duplicate-abbr";
+
 const tester = new TextLintTester();
 tester.run("textlint-rule-no-duplicate-abbr", rule, {
-    valid: ["BGP is Border Gateway Protocol."],
+    valid: ["BGP is Border Gateway Protocol.", "npm module is installed by Node package manager"],
     invalid: [
+        {
+            text: "NPO organization is duplicated",
+            errors: [
+                {
+                    message: `"NPO organization" has duplicated suffix word. "NPO" stands for "Non-Profit Organization".`,
+                    index: 0
+                }
+            ]
+        },
         {
             text: "DAO object is Data Access Object",
             errors: [
                 {
-                    message: `"DAO object" uses duplicated suffix word. "DAO" stands for "Data Access Object".`,
+                    message: `"DAO object" has duplicated suffix word. "DAO" stands for "Data Access Object".`,
                     index: 0
                 }
             ]
@@ -17,7 +27,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {
             text: "This is BGP protocol",
             errors: [
                 {
-                    message: `"BGP protocol" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
+                    message: `"BGP protocol" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
                     index: 8
                 }
             ]
@@ -26,7 +36,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {
             text: "This is BGP protocol",
             errors: [
                 {
-                    message: `"BGP protocol" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
+                    message: `"BGP protocol" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
                     index: 8
                 }
             ]
@@ -35,7 +45,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {
             text: "これはBGPプロトコルです。",
             errors: [
                 {
-                    message: `"BGPプロトコルです。" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
+                    message: `"BGPプロトコルです。" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
                     index: 3
                 }
             ]

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,24 @@`
`1`	`1`	`import TextLintTester from "textlint-tester";`
`2`	`2`	`import rule from "../src/textlint-rule-no-duplicate-abbr";`
	`3`	`+`
`3`	`4`	`const tester = new TextLintTester();`
`4`	`5`	`tester.run("textlint-rule-no-duplicate-abbr", rule, {`
`5`		`- valid: ["BGP is Border Gateway Protocol."],`
	`6`	`+ valid: ["BGP is Border Gateway Protocol.", "npm module is installed by Node package manager"],`
`6`	`7`	`invalid: [`
	`8`	`+ {`
	`9`	`+ text: "NPO organization is duplicated",`
	`10`	`+ errors: [`
	`11`	`+ {`
	`12`	+ message: `"NPO organization" has duplicated suffix word. "NPO" stands for "Non-Profit Organization".`,
	`13`	`+ index: 0`
	`14`	`+ }`
	`15`	`+ ]`
	`16`	`+ },`
`7`	`17`	`{`
`8`	`18`	`text: "DAO object is Data Access Object",`
`9`	`19`	`errors: [`
`10`	`20`	`{`
`11`		- message: `"DAO object" uses duplicated suffix word. "DAO" stands for "Data Access Object".`,
	`21`	+ message: `"DAO object" has duplicated suffix word. "DAO" stands for "Data Access Object".`,
`12`	`22`	`index: 0`
`13`	`23`	`}`
`14`	`24`	`]`
`@@ -17,7 +27,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {`
`17`	`27`	`text: "This is BGP protocol",`
`18`	`28`	`errors: [`
`19`	`29`	`{`
`20`		- message: `"BGP protocol" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
	`30`	+ message: `"BGP protocol" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
`21`	`31`	`index: 8`
`22`	`32`	`}`
`23`	`33`	`]`
`@@ -26,7 +36,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {`
`26`	`36`	`text: "This is BGP protocol",`
`27`	`37`	`errors: [`
`28`	`38`	`{`
`29`		- message: `"BGP protocol" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
	`39`	+ message: `"BGP protocol" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
`30`	`40`	`index: 8`
`31`	`41`	`}`
`32`	`42`	`]`
`@@ -35,7 +45,7 @@ tester.run("textlint-rule-no-duplicate-abbr", rule, {`
`35`	`45`	`text: "これはBGPプロトコルです。",`
`36`	`46`	`errors: [`
`37`	`47`	`{`
`38`		- message: `"BGPプロトコルです。" uses duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
	`48`	+ message: `"BGPプロトコルです。" has duplicated suffix word. "BGP" stands for "Border Gateway Protocol".`,
`39`	`49`	`index: 3`
`40`	`50`	`}`
`41`	`51`	`]`