move setId() from inspect() to find()

Sean Boran · Sean Boran · commit 9d4ed0790e8d · 2015-01-22T14:20:52.000Z
diff --git a/src/Docker/Manager/ImageManager.php b/src/Docker/Manager/ImageManager.php
@@ -90,7 +90,8 @@ public function find($repository, $tag = 'latest')
     {
         $image = new Image($repository, $tag);
 
-        $this->inspect($image);
+        $data = $this->inspect($image);
+        $image->setId($data['Id']);
 
         return $image;
     }
@@ -129,12 +130,7 @@ public function inspect(Image $image)
             throw UnexpectedStatusCodeException::fromResponse($response);
         }
 
-        $data = $response->json();
-
-        $image->setId($data['Id']);
-        // @TODO Add extra info on image
-
-        return $data;
+        return $response->json();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,8 @@ public function find($repository, $tag = 'latest')`
`90`	`90`	`{`
`91`	`91`	`$image = new Image($repository, $tag);`
`92`	`92`
`93`		`- $this->inspect($image);`
	`93`	`+ $data = $this->inspect($image);`
	`94`	`+ $image->setId($data['Id']);`
`94`	`95`
`95`	`96`	`return $image;`
`96`	`97`	`}`
`@@ -129,12 +130,7 @@ public function inspect(Image $image)`
`129`	`130`	`throw UnexpectedStatusCodeException::fromResponse($response);`
`130`	`131`	`}`
`131`	`132`
`132`		`- $data = $response->json();`
`133`		`-`
`134`		`- $image->setId($data['Id']);`
`135`		`- // @TODO Add extra info on image`
`136`		`-`
`137`		`- return $data;`
	`133`	`+ return $response->json();`
`138`	`134`	`}`
`139`	`135`
`140`	`136`	`/**`