You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I am asking "how do we know this works" it is not so much about whether that flag itself works. I'm questioning whether you can just make the affected completion providers run on non-ui thread without throwing 'invalid thread' exceptions and/or misbehaving in any other unexpected ways.
There is actually quite a lot of Eclipse api that just throws invaldid thread excpeption when callled from non-ui thread.
So yeah, testing thoroughly whether the changed completion providers still work is important.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked the SpringBootJavaCompletionProposalComputer as requiresUIThread
= false so that the completions can be run asyncly.
This will make the new java async support to work even when STS4 tooling is installed.