CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
[MRG] Configures Azure Pipelines #13206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I agree. I used azure pipelines for a repo I used to teach a class and i really liked it. I just had issues when installing stuff with conda but maybe those have been fixed :) |
the scikit-learn org apparently has been created a year ago. MS is trying to help us recover it. I suggested to use my account (t3kcit) as a backup. We could also create an sklearn org if that name is available still. |
+1 for you to try to create the sklearn org. |
via email:
|
https://dev.azure.com/the-real-scikit-learn/ is mine now. |
Can you make it public? I get a 401. |
I thought I did. what's your azure ID/email? |
401 Not Authorized Sorry, but Olivier Grisel olivier.grisel@ensta.org (ensta.org) is not authorized to access this page |
For https://dev.azure.com/the-real-scikit-learn/ ? that's weird |
Try https://dev.azure.com/the-real-scikit-learn/scikit-learn/ |
should we merge and try? |
It works. Is there a way to make it public so that people do not have to create a MS account just to see the logs? |
actually false alarm it is public. I just got a weird redirect to a password confirmation page the first time, probably because of my active session. But if I completely log out I can still see the scikit-learn project on azure pipeline. |
I let you invite @thomasjpfan and a bunch scikit-learn core devs to admin this project. |
I already invited thomasjpfan ;) We need the other dev's azure IDs. |
And feel free to merge to run the tests. |
running now :) |
The failure is random. I have seen elsewhere. |
That's a good opportunity to highlight the reporting of the failing tests: |
we didn't intend it to be the case, but those doctests are kinda working as good tests sometimes. I wonder if we need to improve our tests somehow. P.S. Azure Devops ID: adrin,jalali@gmail.com |
Please let me know if you have any other questions or blocking issues and I'll work with you to get them resolved. |
* BLD: Enable azure pipelines * Set up CI with Azure Pipelines * BLD: Azure fix * BLD: Azure fix * TST Test variables * BLD Install scikit-learn * BLD Install scikit-learn * BLD Fix * BLD Test global variables * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Test * BLD Test * BLD Test * BLD Test * BLD Test * BLD Test * CLN Moves matrix to root * CLN Adds coverage * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * CLN Uses system conda * CLN Uses system conda * CLN Fixes spelling * CLN Fixes spelling * Trigger CI * BLD Adds Codecov into script * TST Test codecov * TST Test codecov * TST Test agent workdir * REV Test all of sklearn * REV Includes all tests * TST Uses CODECOV_TOKEN * Trigger CI * CLN Nicer test run title name
This reverts commit 7b83429.
This reverts commit 7b83429.
* BLD: Enable azure pipelines * Set up CI with Azure Pipelines * BLD: Azure fix * BLD: Azure fix * TST Test variables * BLD Install scikit-learn * BLD Install scikit-learn * BLD Fix * BLD Test global variables * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Fix * BLD Test * BLD Test * BLD Test * BLD Test * BLD Test * BLD Test * CLN Moves matrix to root * CLN Adds coverage * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * BLD Windows * CLN Uses system conda * CLN Uses system conda * CLN Fixes spelling * CLN Fixes spelling * Trigger CI * BLD Adds Codecov into script * TST Test codecov * TST Test codecov * TST Test agent workdir * REV Test all of sklearn * REV Includes all tests * TST Uses CODECOV_TOKEN * Trigger CI * CLN Nicer test run title name
Considering release pipelines, would you mind adding me (by my gmail
address) to the Azure DevOps org, @amueller?
|
@thomasfan can take this, I think ;) |
Reference Issues/PRs
Resolves #12986
What does this implement/fix? Explain your changes.
Adds configuration for azure pipelines for linux, windows, and osx. Here is what it looks like: https://dev.azure.com/thomasjpfan/scikit-learn/_build/results?buildId=84
junitxml is configured, so we do not need to scroll down to see errors anymore, the traceback and errors are shown in the UI: https://dev.azure.com/thomasjpfan/scikit-learn/_build/results?buildId=84&view=ms.vss-test-web.build-test-results-tab
Any other comments?
The linux and osx tests are the same as the tests we run on travis CI.
For windows the difference between appveyor and azure is:
I have not found a nice way to add
CODECOV_TOKEN
to the environment besides library variable groups. @mickeygousset What would you recommend if we need to set private env variables?Edit: To enable codecov, follow the advice from #13206 (comment) and a new secret variable called CODECOV_TOKEN.
CC @amueller