CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Fix for split gates enabled quantizable LSTM subclass #140818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140818
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 645bd9e with merge base e2e67a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D65989314 |
@pytorchmergebot help |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchmergebot merge |
This PR needs to be approved by an authorized maintainer before merge. |
Please wait for CI to pass before merging :) |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314 Pull Request resolved: pytorch#140818 Approved by: https://github.com/andrewor14
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314 Pull Request resolved: pytorch#140818 Approved by: https://github.com/andrewor14
Summary:
Motivation
In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests.
What's the change?
As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set.
Test Plan:
Reviewed By: andrewor14
Differential Revision: D65989314