| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:51:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=425.834643,conversation_content-fragment;desc="conversation_content fragment";dur=912.784571,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=409.674253,nginx;desc="NGINX";dur=1.626133,glb;desc="GLB";dur=106.743173
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TNlc9vjwZinTVEp7Z0UKN0pX9RKjIv4D1HIWD59D6K4TSyFKII2zJF2FkQRIbzldUc1eCnnIk3no6rK4X6DS4hiVz2OG7fG%2FlegsdA8Hddjhf8KllyBZidPY2MuQIXKCp0LobRfXdrUxXCk8y6gOpi30Xwkan0owlKiVLG24nQPgled%2Bdp0PBWsZ%2FifbOTBu%2F4w2ziUhQXPPPObgXMEi4BzYTEv7KAk82xsxb5TBoirb%2F4u40l1fXEGLO604GGRmtBFsd0TUDUe3fFrfEGFRSw%3D%3D--%2BMFGaNmJA1lBdVCf--FPvmJ4cL%2BmaXT243tsx91A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1020503589.1753426292; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:51:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:51:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A77A:2B2ABB:3C86C9:4B10B6:68832974
Fix for split gates enabled quantizable LSTM subclass by Ninja91 · Pull Request #140818 · pytorch/pytorch · GitHub
pytorch-bot
bot
added
release notes: quantization
release notes category
release notes: AO frontend
labels
Nov 15, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Fix for split gates enabled quantizable LSTM subclass #140818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140818
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 645bd9e with merge base e2e67a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
release notes: quantization
|
This pull request was exported from Phabricator. Differential Revision: D65989314 |
|
@pytorchmergebot help |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchmergebot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
andrewor14
approved these changes
Nov 15, 2024
|
Please wait for CI to pass before merging :) |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314 Pull Request resolved: pytorch#140818 Approved by: https://github.com/andrewor14
fmo-mt
pushed a commit
to fmo-mt/pytorch
that referenced
this pull request
Dec 11, 2024
Summary: ### Motivation In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests. ### What's the change? As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set. Test Plan: - N6206576 - CI. Reviewed By: andrewor14 Differential Revision: D65989314 Pull Request resolved: pytorch#140818 Approved by: https://github.com/andrewor14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
release notes: AO frontend
release notes: quantization
release notes category
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary:
Motivation
In D65283170, we need subclass of quantizable LSTM to enable split_gates. Also, required for tests.
What's the change?
As subclass is not part of no_observer() set, an improper observer is added after the quantizable LSTM module. Here, we switch class check change to issubclass check on no_observer set.
Test Plan:
Reviewed By: andrewor14
Differential Revision: D65989314