Port X86_F16 from executorch half to PyTorch half #140720

swolchok · 2024-11-14T16:32:18Z

Stack from ghstack (oldest at bottom):

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature.

Differential Revision: D65949409

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]

pytorch-bot · 2024-11-14T16:32:23Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140720

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 15edd3c with merge base 891ba2e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-14T16:32:37Z

This pull request was exported from Phabricator. Differential Revision: D65949409

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) ghstack-source-id: 253567897 Pull Request resolved: #140720

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]

facebook-github-bot · 2024-11-14T18:34:19Z

This pull request was exported from Phabricator. Differential Revision: D65949409

Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253592160 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]

Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253799376 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)

facebook-github-bot · 2024-11-15T18:18:10Z

This pull request was exported from Phabricator. Differential Revision: D65949409

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]

facebook-github-bot · 2024-11-15T19:13:59Z

This pull request was exported from Phabricator. Differential Revision: D65949409

Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253813016 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)

swolchok · 2024-11-18T18:56:55Z

I think this one is not ready for land yet; surprised checks pass because I think I'm seeing a failure internally. need to investigate

malfet · 2024-11-18T19:02:02Z

c10/util/Half.h

+#if defined(__x86_64__) || defined(_M_X64) || defined(__i386) || \
+    defined(_M_IX86)
+#if defined(__F16C__)
+#define X86_F16 1


Should it be something like _HAS_X86_64_F16 (to avoid even a slight possibility of name collision)

malfet · 2024-11-18T19:02:10Z

@pytorchbot merge

pytorchmergebot · 2024-11-18T19:03:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

facebook-github-bot · 2024-11-19T00:27:43Z

This pull request was exported from Phabricator. Differential Revision: D65949409

facebook-github-bot · 2024-11-19T15:47:20Z

This pull request was exported from Phabricator. Differential Revision: D65949409

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: #140994 Approved by: https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: #141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720, #140994

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

Port X86_F16 from executorch half to PyTorch half

3e3637e

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]

This was referenced Nov 14, 2024

move c10::overflows to its own header #140564

Closed

Move complex<Half> from Half.h to complex.h #140565

Closed

Add C10_EMBEDDED to gate ostream usage in Half/BFloat16 #140566

Closed

swolchok mentioned this pull request Nov 14, 2024

Remove UB type punning from c10/util/floating_point_utils.h #140567

Closed

facebook-github-bot added the fb-exported label Nov 14, 2024

swolchok added release notes: performance_as_product release notes: cpp release notes category and removed release notes: cpp release notes category labels Nov 15, 2024

swolchok requested a review from malfet November 15, 2024 22:01

malfet approved these changes Nov 18, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 18, 2024

malfet reviewed Nov 18, 2024

View reviewed changes

pytorchmergebot added the merging label Nov 18, 2024

pytorchmergebot added the Merged label Nov 18, 2024

pytorchmergebot closed this in 17bb78a Nov 18, 2024

pytorchmergebot removed the merging label Nov 18, 2024

swolchok mentioned this pull request Nov 19, 2024

Fix Half X86_F16 CUDA build failure #140994

Closed

swolchok mentioned this pull request Nov 19, 2024

Use std::bit_cast as c10::bit_cast if available #141035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port X86_F16 from executorch half to PyTorch half #140720

Port X86_F16 from executorch half to PyTorch half #140720

Uh oh!

swolchok commented Nov 14, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Nov 14, 2024 •

edited

Loading

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 15, 2024

Uh oh!

facebook-github-bot commented Nov 15, 2024

Uh oh!

swolchok commented Nov 18, 2024

Uh oh!

malfet Nov 18, 2024

Uh oh!

malfet commented Nov 18, 2024

Uh oh!

pytorchmergebot commented Nov 18, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

Uh oh!

Port X86_F16 from executorch half to PyTorch half #140720

Port X86_F16 from executorch half to PyTorch half #140720

Uh oh!

Conversation

swolchok commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140720

❗ 2 Active SEVs

✅ No Failures

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 15, 2024

Uh oh!

facebook-github-bot commented Nov 15, 2024

Uh oh!

swolchok commented Nov 18, 2024

Uh oh!

malfet Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

malfet commented Nov 18, 2024

Uh oh!

pytorchmergebot commented Nov 18, 2024

Merge started

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

Uh oh!

swolchok commented Nov 14, 2024 •

edited

Loading

pytorch-bot bot commented Nov 14, 2024 •

edited

Loading