| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 22 Jul 2025 01:57:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=435.505119,conversation_content-fragment;desc="conversation_content fragment";dur=1369.71852,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=325.884275,nginx;desc="NGINX";dur=1.515105,glb;desc="GLB";dur=103.455206
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XvU7kwYpy9kd33O%2F3YRDKYoPDXZ0PyfwJaz4zH%2BrjBWv8IG5pV8pTLbbhlZ%2BpU5X97j5Nbh2Om8NquNGPmJ4oEfIldeKGBKk6PhJyNdz9eRA0GOt5IheW4jROKT%2BUjY8dYNPvVdL9WC8qhphhhVhFkOVVjZ53IHqNdkQX51ak8PU%2BzLlM8MK73O7sTXkmAOz9ZA3f3yY0WLgu%2BE9H%2F4iy%2FrHWtpKTzE7BixiC68VVBturVbBqJWJAxqVF5j%2BSzWCOyi0qMhPLuxiDNiZ4Qfelw%3D%3D--ttUFGm3%2FcK%2F8h4Tb--uaHtJ6Dgk7uhfTWyUNF05Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1794611621.1753149424; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 01:57:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 01:57:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A198:2A7C3D:5B4CE:8A036:687EEFF0
[PyTorch] Hook up fp16_gemv_trans to gemv fast path for non-aarch64 architectures by swolchok · Pull Request #138005 · pytorch/pytorch · GitHub
swolchok
requested review from
albanD and
malfet
and removed request for
albanD
October 17, 2024 23:04
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[PyTorch] Hook up fp16_gemv_trans to gemv fast path for non-aarch64 architectures #138005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rchitectures Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138005
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0bd8d1f with merge base 86602a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 15, 2024
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
swolchok
added a commit
that referenced
this pull request
Oct 15, 2024
…rchitectures Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) ghstack-source-id: 248140851 Pull Request resolved: #138005
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
swolchok
requested review from
albanD and
malfet
and removed request for
albanD
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
swolchok
added a commit
that referenced
this pull request
Oct 24, 2024
…rchitectures Pull Request resolved: #138005 Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. ghstack-source-id: 249911241 @exported-using-ghexport Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/)
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 28, 2024
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 29, 2024
malfet
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but we should have half_one and half_zero constants somewhere to avoid doing casts all the time
Comment on lines
+305
to
+306
| alpha.x == fp16_ieee_from_fp32_value(1.0f) && | ||
| beta.x == fp16_ieee_from_fp32_value(0.0f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fp16_ieee_from_fp32_value calls are very slow, but we have one and zero constants, don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fp16_ieee_from_fp32_value calls are very slow
above comment demonstrates it's constant-foldable
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: #138275 Approved by: https://github.com/malfet ghstack dependencies: #139082, #139083, #137918, #138005
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…rchitectures (pytorch#138005) Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) Pull Request resolved: pytorch#138005 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: pytorch#138275 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918, pytorch#138005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
topic: performance
topic category
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Stack from ghstack (oldest at bottom):
Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv.
Differential Revision: D64351092