| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 16:04:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=431.381192,conversation_content-fragment;desc="conversation_content fragment";dur=974.14841,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=455.736493,nginx;desc="NGINX";dur=0.630352,glb;desc="GLB";dur=95.839319
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RdxeL5AWC622PF9XXQzMh8Oa%2BXy8EH5K2ZTJR9Ri87itLc0jbWfiwbg5RjrqDVN9JfH4%2FPzBN%2Frw32NICglAIKFNMW0gE4ceKWU1LvIEYsN4PcNDz1cvQ7HGBjvQpjs4DltNKaxIpEeZHJe1EYPDt3OEe31z%2FriCibSayZeAgib4Se86hItY3aeNNgzhP552ilYzDn6LVVo2MS8TGN%2BZVWAeI8z6ndH8bMBgJcHHvl5gsDMkoBn9V9c2pQOIS%2BrdIdFdtOLkNRXmNZeS5pP%2Bsg%3D%3D--sWJqFmvBYxQFeD%2F%2F--hkP3pk22ngeRMbAhlmQ2LQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1955066157.1753113893; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:04:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:04:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E50:36713F:BF025:E00F9:687E6525
[Intel GPU] Avoid atomic add for XPU device in satter_add by deterministic mode by PenghuiCheng · Pull Request #137966 · pytorch/pytorch · GitHub
EikanWang
changed the title
avoid gpuAtomicAdd for XPU device for satter_add by deterministic mode
[WIP] avoid gpuAtomicAdd for XPU device for satter_add by deterministic mode
Oct 15, 2024
EikanWang
added
topic: not user facing
topic category
ciflow/xpu
Run XPU CI tasks
labels
Oct 15, 2024
PenghuiCheng
changed the title
[WIP] avoid gpuAtomicAdd for XPU device for satter_add by deterministic mode
[WIP] avoid atomic add for XPU device in satter_add by deterministic mode
Oct 16, 2024
PenghuiCheng
force-pushed
the
penghuic/scatter_add_deterministic
branch
2 times, most recently
from
November 7, 2024 08:08
PenghuiCheng
force-pushed
the
penghuic/scatter_add_deterministic
branch
from
November 11, 2024 02:31
EikanWang
changed the title
[WIP] avoid atomic add for XPU device in satter_add by deterministic mode
[Intel GPU] Avoid atomic add for XPU device in satter_add by deterministic mode
Nov 11, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[Intel GPU] Avoid atomic add for XPU device in satter_add by deterministic mode #137966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
PenghuiCheng
wants to merge
2
commits into
pytorch:main
from
PenghuiCheng:penghuic/scatter_add_deterministic
Closed
[Intel GPU] Avoid atomic add for XPU device in satter_add by deterministic mode #137966
PenghuiCheng
wants to merge
2
commits into
pytorch:main
from
PenghuiCheng:penghuic/scatter_add_deterministic
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137966
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1b26d16 with merge base 565a794 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
changed the title
|
May I know what's the impact? Does it lead to any case failure? |
EikanWang
added
topic: not user facing
|
Please seek CI approval before scheduling CIFlow labels |
|
Please add test cases. |
PenghuiCheng
changed the title
4 tasks
Yes, the UT covered in https://github.com/intel/torch-xpu-ops/blob/main/test/xpu/test_scatter_gather_ops_xpu.py. |
PenghuiCheng
force-pushed
the
penghuic/scatter_add_deterministic
branch
2 times, most recently
from
3d7a311 to
fc26d80
Compare
Signed-off-by: Cheng Penghui <penghui.cheng@intel.com>
PenghuiCheng
force-pushed
the
penghuic/scatter_add_deterministic
branch
from
fc26d80 to
1b26d16
Compare
EikanWang
changed the title
EikanWang
approved these changes
Nov 11, 2024
guangyey
approved these changes
Nov 12, 2024
ezyang
approved these changes
Nov 13, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…istic mode (pytorch#137966) The "scatter_add" op with the deterministic mode in XPU device is not implemented, it will report that "scatter_add_kernel" does not have a deterministic implementation in UT. Just like the implementation of CUDA, we need to check _deterministic_algorithms in scatter_add op for the XPU device. The UT is in: https://github.com/intel/torch-xpu-ops/blob/main/test/xpu/test_scatter_gather_ops_xpu.py. We reused [PyTorch UT code]( https://github.com/pytorch/pytorch/blob/96b30dcb25c80513769dae2a8688aec080b00117/test/test_scatter_gather_ops.py#L233). Now the UT case is [skipped in torch-xpu-ops test](https://github.com/intel/torch-xpu-ops/blob/4fa7921f1e9a0bf300d25da9b8758524f2751092/test/xpu/skip_list_common.py#L731). Will open it when this PR is merged. Pull Request resolved: pytorch#137966 Approved by: https://github.com/EikanWang, https://github.com/guangyey, https://github.com/ezyang
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
ciflow/xpu
Run XPU CI tasks
Merged
open source
topic: not user facing
topic category
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The "scatter_add" op with the deterministic mode in XPU device is not implemented, it will report that "scatter_add_kernel" does not have a deterministic implementation in UT.
Just like the implementation of CUDA, we need to check _deterministic_algorithms in scatter_add op for the XPU device.
The UT is in: https://github.com/intel/torch-xpu-ops/blob/main/test/xpu/test_scatter_gather_ops_xpu.py. We reused PyTorch UT code.
Now the UT case is skipped in torch-xpu-ops test. Will open it when this PR is merged.