CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Document that load_inline requires having a compiler installed #137521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
đź”— Helpful Linksđź§Ş See artifacts and rendered test results at hud.pytorch.org/pr/137521
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit e5bfb1f with merge base 2268319 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but @malfet would know better if we can make this more precise
…or load_inline" Prompted by this forum q: https://discuss.pytorch.org/t/are-the-requirements-for-using-torch-utils-cpp-extension-with-cuda-documented-anywhere/211222 Would be curious to know if we could get more precise. [ghstack-poisoned]
torch/utils/cpp_extension.py
Outdated
a CUDA extension, you will need to additionally install the corresponding CUDA nvcc | ||
and any other dependencies your code has. Compiling toolchains are not included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would name this "cuda toolkit (that contains nvcc and necessary headers in particular)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this cuda toolkit the same one available on conda? Cuz the forum q poster mentioned installing this and having it not be enough
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
…lled" Prompted by this forum q: https://discuss.pytorch.org/t/are-the-requirements-for-using-torch-utils-cpp-extension-with-cuda-documented-anywhere/211222 Would be curious to know if we could get more precise. [ghstack-poisoned]
…lled" Prompted by this forum q: https://discuss.pytorch.org/t/are-the-requirements-for-using-torch-utils-cpp-extension-with-cuda-documented-anywhere/211222 Would be curious to know if we could get more precise. [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Prompted by this forum q: https://discuss.pytorch.org/t/are-the-requirements-for-using-torch-utils-cpp-extension-with-cuda-documented-anywhere/211222
Would be curious to know if we could get more precise.
Stack from ghstack (oldest at bottom):