| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 16:02:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=373.840456,conversation_content-fragment;desc="conversation_content fragment";dur=880.860041,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=430.14061,nginx;desc="NGINX";dur=1.34002,glb;desc="GLB";dur=94.822008
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Sw0Mai0npSxz81Nodg9MHwJGvhdjsrE%2BkgH7qSHuz52EfrkVyz2hkHjFgEZ0rPmedkifi%2Bp2yXiUxo%2BxJfOyrXK1RiLw2ovY5LAGF%2FDYiK47h%2BWSJM5w8i2V3DuSHsA3AnpynmWcALEGyJzL%2BFEuj7bYqujKaRR2bkhw1kxLpjBXd8jE62ZH2QudpJuDGsuD9w2s9WsEPyN2goONVJON1lF0lRQc1aK81x2FtmqIyrtSDab77VjVuKcZlb79W3IeP0SuvWk509HORzbjKEZP%2Fw%3D%3D--gj%2FCpj%2FtWMF9oNEk--iAlnln1nLT2asIYSbNQQgw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.761431425.1753113738; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:02:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:02:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DB26:9952B:BCF55:DCC7A:687E648A
[export] fix _get_non_persistent_buffers for duplicates by pianpwk · Pull Request #136552 · pytorch/pytorch · GitHub
pianpwk
requested review from
avikchaudhuri,
tugsbayasgalan,
zhxchen17,
ydwu4 and
angelayi
as code owners
September 24, 2024 18:05
facebook-github-bot
force-pushed
the
export-D63332976
branch
from
September 24, 2024 18:49
pianpwk
force-pushed
the
export-D63332976
branch
from
September 24, 2024 18:51
pianpwk
force-pushed
the
export-D63332976
branch
from
September 24, 2024 20:27
pianpwk
force-pushed
the
export-D63332976
branch
from
September 24, 2024 21:19
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[export] fix _get_non_persistent_buffers for duplicates #136552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pianpwk
requested review from
avikchaudhuri,
tugsbayasgalan,
zhxchen17,
ydwu4 and
angelayi
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136552
Note: Links to docs will display an error until the docs builds have been completed. âś… You can merge normally! (1 Unrelated Failure)As of commit a90f131 with merge base 95c0f74 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63332976 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Summary: Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules. Test Plan: test_export Differential Revision: D63332976
facebook-github-bot
force-pushed
the
export-D63332976
branch
from
e663a61 to
7545237
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63332976 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63332976 |
pianpwk
force-pushed
the
export-D63332976
branch
from
7545237 to
09cd257
Compare
pianpwk
added a commit
that referenced
this pull request
Sep 24, 2024
Summary: Pull Request resolved: #136552 Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules. Test Plan: test_export Differential Revision: D63332976
avikchaudhuri
approved these changes
Sep 24, 2024
tugsbayasgalan
approved these changes
Sep 24, 2024
pianpwk
added a commit
that referenced
this pull request
Sep 24, 2024
Summary: Pull Request resolved: #136552 Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules. Test Plan: test_export Reviewed By: avikchaudhuri, tugsbayasgalan Differential Revision: D63332976
pianpwk
force-pushed
the
export-D63332976
branch
from
09cd257 to
db7c1ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63332976 |
Summary: Pull Request resolved: #136552 Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules. Test Plan: test_export Reviewed By: avikchaudhuri, tugsbayasgalan Differential Revision: D63332976
|
This pull request was exported from Phabricator. Differential Revision: D63332976 |
pianpwk
force-pushed
the
export-D63332976
branch
from
db7c1ba to
a90f131
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
Summary: Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules. Test Plan: test_export Differential Revision: D63332976 Pull Request resolved: pytorch#136552 Approved by: https://github.com/avikchaudhuri, https://github.com/tugsbayasgalan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary: Export's method _get_non_persistent_buffers doesn't check duplicate submodules, so we run into state_dict related issues if non-persistent buffers exist on shared submodules.
Test Plan: test_export
Differential Revision: D63332976