CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[AMD] Turn on fast path for index_put #136136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
đź”— Helpful Linksđź§Ş See artifacts and rendered test results at hud.pytorch.org/pr/136136
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit c777e69 with merge base 8316f9b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D62731130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jeffdaily does the ciflow/rocm label trigger some additional AMD specific CI? |
We have a limited pool of CI servers. The ciflow/trunk will trigger a fraction of the full CI suite (no inductor, a select set of test modules, etc). OTOH, ciflow/rocm runs much more. We try to limit using ciflow/rocm on PRs because it puts pressure on our CI resources. We have the authority to revert merged PRs if they break ROCm, in which case we add the ciflow/rocm label to the reverted PR to aid the PR author in fixing the issue for ROCm. |
Summary: This slow path is bad because it has a sync point which makes CPU really slow. I'm not very sure if AMD actually needs this with the newer rocm versino {F1870213925} Test Plan: CI Reviewed By: danzimm Differential Revision: D62731130
58ff182
to
c777e69
Compare
This pull request was exported from Phabricator. Differential Revision: D62731130 |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: This slow path is bad because it has a sync point which makes CPU really slow. I'm not very sure if AMD actually needs this with the newer rocm versino {F1870213925} Test Plan: CI Differential Revision: D62731130 Pull Request resolved: pytorch#136136 Approved by: https://github.com/danzimm, https://github.com/jeffdaily, https://github.com/eqy
Summary: This slow path is bad because it has a sync point which makes CPU really slow. I'm not very sure if AMD actually needs this with the newer rocm versino {F1870213925} Test Plan: CI Differential Revision: D62731130 Pull Request resolved: pytorch#136136 Approved by: https://github.com/danzimm, https://github.com/jeffdaily, https://github.com/eqy
Summary: This slow path is bad because it has a sync point which makes CPU really slow. I'm not very sure if AMD actually needs this with the newer rocm versino {F1870213925} Test Plan: CI Differential Revision: D62731130 Pull Request resolved: pytorch#136136 Approved by: https://github.com/danzimm, https://github.com/jeffdaily, https://github.com/eqy
Summary:
This slow path is bad because it has a sync point which makes CPU really slow. I'm not very sure if AMD actually needs this with the newer rocm versino
{F1870213925}
Test Plan: CI
Differential Revision: D62731130