Tbmr features (purely topological adaptation on MSER) #2713

crownedone · 2020-10-15T14:13:34Z

Merge with extra: opencv/opencv_extra#817

Some questions:

Generalized Component tree calculation could be an additional feature, instead of hiding in the implementation of TBMR (as it can be used by MSER, TBMR, ...). I could do an extra module for that (where)?
Is this the right place for TBMR? (In xFeatures2d)

Thanks for your work!

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test
The feature is well documented.
and sample code can be built with the project CMake

restructure component tree calculation. remove sort_indexes by using cv::sortIdx.

…tes.

crownedone · 2020-11-16T09:02:23Z

I do not understand, why the builds fail. Its related to python wrapper. Help appreciated!

alalek

Keep patch clean and minimal for reviewing.

modules/xfeatures2d/include/opencv2/xfeatures2d.hpp

alalek

Thank you for contribution!

Please take a look on comments below.

modules/xfeatures2d/src/tbmr.cpp

add export wrappers

alalek

Well done. Thank you for updates!

modules/xfeatures2d/include/opencv2/xfeatures2d.hpp

modules/xfeatures2d/src/msd_pyramid.hpp

modules/xfeatures2d/test/test_features2d.cpp

fix correct license text

alalek

Well done!

crownedone · 2020-11-19T07:17:04Z

Thanks!

steffen.ehrle added 17 commits October 13, 2020 11:03

initial commit

44c359d

fix test data reusing stereomatching testdata.

a2ee31b

fix incorrect function, ellipse notation, types and comments.

dfc9cf9

add required precomp.hpp, fix warnings.

f34c6a6

fix naming

4f2191c

remove ocl for now. (we want to add opencl functionality later)

c396037

update readme

810eecb

fix invalid module dependency.

4bfebc5

add angle, minAxis and majAxis calculation.

70df975

formatting fixes.

592dd32

restructure component tree calculation. remove sort_indexes by using cv::sortIdx.

fix test using virtual data.

fb73bcc

move tbmr to xfeatures2d. Add standard tests in xFeatures2d.

3c59b3c

octave/scale and descriptor extraction using sift added

2eaff86

try fix the errors

3223f46

fix parameter error

64537c6

add scale for pyramid extraction and filter scaled points for duplica…

187d8cb

…tes.

fix exports

cd2909a

alalek requested changes Nov 16, 2020

View reviewed changes

modules/xfeatures2d/include/opencv2/xfeatures2d.hpp Outdated Show resolved Hide resolved

steffen.ehrle added 2 commits November 16, 2020 12:19

remove unrelated changes due to indentation

7b71411

remove unrelated indentation changes in tests

0c96156

alalek reviewed Nov 16, 2020

View reviewed changes

modules/xfeatures2d/include/opencv2/xfeatures2d.hpp Show resolved Hide resolved

alalek reviewed Nov 16, 2020

View reviewed changes

modules/xfeatures2d/src/tbmr.cpp Outdated Show resolved Hide resolved

modules/xfeatures2d/src/tbmr.cpp Outdated Show resolved Hide resolved

steffen.ehrle added 2 commits November 16, 2020 13:50

externalize msd_pyramid

117abe4

add export wrappers

exchange malloc/calloc with AutoBuffer

0245d3a

alalek reviewed Nov 16, 2020

View reviewed changes

modules/xfeatures2d/include/opencv2/xfeatures2d.hpp Outdated Show resolved Hide resolved

modules/xfeatures2d/src/msd_pyramid.hpp Outdated Show resolved Hide resolved

modules/xfeatures2d/test/test_features2d.cpp Show resolved Hide resolved

fix warning

ef488ea

fix correct license text

crownedone mentioned this pull request Nov 16, 2020

Tbmr features (testdata) opencv/opencv_extra#817

Merged

alalek approved these changes Nov 18, 2020

View reviewed changes

alalek merged commit 672ba70 into opencv:master Nov 18, 2020

crownedone deleted the tbmr_features branch November 20, 2020 08:43

alalek mentioned this pull request Nov 27, 2020

Merge 4.x #2768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tbmr features (purely topological adaptation on MSER) #2713

Tbmr features (purely topological adaptation on MSER) #2713

Uh oh!

crownedone commented Oct 15, 2020 •

edited by alalek

Loading

Uh oh!

crownedone commented Nov 16, 2020

Uh oh!

alalek left a comment

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Uh oh!

crownedone commented Nov 19, 2020

Uh oh!

Uh oh!

Tbmr features (purely topological adaptation on MSER) #2713

Tbmr features (purely topological adaptation on MSER) #2713

Uh oh!

Conversation

crownedone commented Oct 15, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

crownedone commented Nov 16, 2020

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

crownedone commented Nov 19, 2020

Uh oh!

Uh oh!

crownedone commented Oct 15, 2020 •

edited by alalek

Loading