BRISQUE No Reference Image Quality Assessment (IQA) API #2015

krshrimali · 2019-02-26T21:16:07Z

This pullrequest changes

Implements NR-IQA algorithm: Blind/Referenceless Image Spatial QUality Evaluator (BRISQUE) ( Feature Request: BRISQUE NR-IQA Implementation #1983 )
Updates README for Quality API in opencv_contrib (
- Adds Python Samples and C++ Samples for NR-IQA and FR-IQA methods

Thanks to @clunietp for all the help in getting this ready according to the interface of existing Quality API.

catree · 2019-02-27T09:13:48Z

modules/quality/src/qualitybrisque.cpp

+https://www.utexas.edu), is acknowledged in any publication that reports research using this code. The research
+is to be cited in the bibliography as:
+
+1) A. Mittal, A. K. Moorthy and A. C. Bovik, "BRISQUE Software Release",


Can you add also a reference about the BRISQUE algorithm and the software release in the bibliography?

See for instance the xobjdetect.bib file. You can then cite the paper in the doxygen documentation, e.g. @cite Mittal12

@catree Thanks! I've added the bibliography and cited in both header and main C++ files.

alalek

Please reuse SVM implementation from OpenCV ML module. RBF SVM kernel should be available here.

alalek · 2019-03-02T07:46:46Z

modules/quality/include/opencv2/quality/libsvm/svm.hpp

+
+    extern int libsvm_version;
+
+    struct svm_node


Take a look on OpenCV ML module instead of trying to put libsvm into OpenCV.

Hi, I had tried this before and the brisque_allmodel.dat (model file) only supports LIBSVM. I'll try once again and let you know what exactly might be the issue. Thanks!

alalek · 2019-03-02T07:49:21Z

modules/quality/CMakeLists.txt

@@ -1,2 +1,5 @@
 set(the_description "Image Quality Analysis API")
 ocv_define_module(quality opencv_core opencv_imgproc WRAP python)
+ocv_add_testdata(testdata/ contrib/quality
+    FILES_MATCHING PATTERN "*.dat"


testdata should go into opencv_extra repository (create PR with the same source branch name).

We put into repository only small enough data files which is used/shared with "samples" (like text detection models).

alalek

Great work!

alalek · 2019-03-13T10:37:30Z

modules/quality/samples/brisque_trainer_livedb.cpp

+
+    // collects training data from LIVE R2 database
+    // returns {features, responses}, 1 row per image
+    std::pair<cv::Mat, cv::Mat> collect_data_live_r2(const std::string& foldername)


BTW, you can use "static" here instead of anonymous namespace.

alalek · 2019-03-13T11:42:00Z

modules/quality/include/opencv2/quality/qualitybrisque.hpp

+/**
+@brief BRISQUE (Blind/Referenceless Image Spatial Quality Evaluator) is a type of No Reference
+Image Quality Assessment. It measures score based on extracting Natural Scene Satistics (https://en.wikipedia.org/wiki/Scene_statistics)
+and calculating feature vectors. @cite Mittal2 for original paper and @cite Mittal2_software for original implementation.


Please add extra line after the first sentence to separate "brief" and "details" sections.

Sentence with citations can be improved.

Documentation preview for this patch is here

I agree this needs improvement. That preview is very helpful, thanks for the link

Set BRISQUE expected scores from original impl Added BRISQUE models and interface, test methods [alalek] drop changes from libsvm files

Minor edits minor edits double* to vector<data> Updates: BRISQUE and Python Added BRISQUE and Python Samples Minor edits Final edits: BRISQUE Final edits: BRISQUE Copyright notice added deleted .vscode Warnings rectified. Added CV_Assert Final Commit: BRISQUE Removed whitespaces. Corrected array initializations and override warnings Removed whitespaces Resolved array initialization Override warning Mac build resolved Added bibliography and corrected Mac/Android/iOS warnings Rollback changes Added BRISQUE bib Solves Mac/iOS/Android warnings Removed trailing whitespaces Updated sample code for BRISQUE C++ Fixes for Win32, Win64 Warnings removed trailing whitespaces Trailing whitespace removed

…cumentation. Provided cpp samples for model training and evaluation. Fixes for warnings Improved BRISQUE documentation Fixed documentation typo

alalek · 2019-03-16T21:31:22Z

Looks good to me!

For PRs with many commits we usually squash commits onto one commit during merge, but for this PR there are two authors. So I squashed "fixup"/"update" commits and removed libsvm changes from git history.
Original commits are saved here: https://github.com/alalek/opencv_contrib/commits/pr2015_origin

alalek

Well done! Thank you 👍

clunietp · 2019-03-18T19:32:27Z

Thank you @alalek ! Nice job @krshrimali !

krshrimali · 2019-03-19T01:45:22Z

Thanks, @alalek! And thanks a lot @clunietp - You were of great help.

VenkatKrish17 · 2019-06-12T02:49:07Z

Hi,
I am trying to use this algorithm in android. any help I could get? which opencv version will be the best fit for it? because when I used 3.4.6 I was unable to load the model. (.yml) file.

clunietp · 2019-06-12T10:21:01Z

@VenkatKrish17 , have you tried OpenCV >= 4.0?

VenkatKrish17 · 2019-06-12T13:35:10Z

@clunietp Yes. I do run with Opencv 4.1.0 and i face the error "missing or invalid svm type in function 'read_params' ".
I loaded the same model in my simple python code and it works smooth.
I was able to read the model file manually in my android code and see the contents. I read some blogs suggesting to downgrade to opencv 2.4+ so that the load function is available. Is that the reason ? or am I doing wrong ?

clunietp · 2019-06-12T13:46:57Z

Hmm I'll have to take a look when I get more time. Do you happen to have a call stack, and sample code to reproduce? I'm guessing it's in the brisque constructor

clunietp · 2019-06-12T21:16:36Z

@VenkatKrish17 looking into the code, the BRISQUE constructor just calls cv::ml::SVM::load(model_file_path) If you call this directly on Android, what is the result?

Looking at the source of svm.cpp ( https://github.com/opencv/opencv/blob/master/modules/ml/src/svm.cpp ), I'm not sure why this would happen, other than a pointer to a missing/invalid file perhaps.

VenkatKrish17 · 2019-06-15T03:11:32Z

Hmm I'll have to take a look when I get more time. Do you happen to have a call stack, and sample code to reproduce? I'm guessing it's in the brisque constructor

Hi, I will share the code snippet soon. Thanks for your reply.

omarDG · 2020-10-29T13:07:04Z

@VenkatKrish17 did get it work on Android? can you update us on that?

catree reviewed Feb 27, 2019

View reviewed changes

alalek reviewed Mar 2, 2019

View reviewed changes

alalek reviewed Mar 13, 2019

View reviewed changes

clunietp and others added 3 commits March 16, 2019 21:19

BRISQUE initial commit

476167e

Set BRISQUE expected scores from original impl Added BRISQUE models and interface, test methods [alalek] drop changes from libsvm files

Updated to use OpenCV ML, removed libsvm. Updated model, tests and do…

ebad13e

…cumentation. Provided cpp samples for model training and evaluation. Fixes for warnings Improved BRISQUE documentation Fixed documentation typo

alalek approved these changes Mar 18, 2019

View reviewed changes

opencv-pushbot merged commit ebad13e into opencv:master Mar 18, 2019

opencv-pushbot pushed a commit that referenced this pull request Mar 18, 2019

Merge pull request #2015 from krshrimali:krshrimali-patch-brisque

fd2ca91

BRISQUE No Reference Image Quality Assessment (IQA) API #2015

BRISQUE No Reference Image Quality Assessment (IQA) API #2015

Uh oh!

Conversation

krshrimali commented Feb 26, 2019 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pullrequest changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek commented Mar 16, 2019

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

clunietp commented Mar 18, 2019

Uh oh!

krshrimali commented Mar 19, 2019

Uh oh!

VenkatKrish17 commented Jun 12, 2019

Uh oh!

clunietp commented Jun 12, 2019

Uh oh!

VenkatKrish17 commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clunietp commented Jun 12, 2019

Uh oh!

clunietp commented Jun 12, 2019

Uh oh!

VenkatKrish17 commented Jun 15, 2019

Uh oh!

omarDG commented Oct 29, 2020

Uh oh!

Uh oh!

krshrimali commented Feb 26, 2019 •

edited by alalek

Loading

VenkatKrish17 commented Jun 12, 2019 •

edited

Loading