You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please review both interface design and code. ๐
Motivation
Stateful kernel in C++ is really useful to many usecases like tracking.
This PR will enable python G-API users to use stateful kernel and expand the usecases in python G-API.
Feature Design
Here is the example video and the example code of this feature.
The example kernel is like this.
Basically it create internal state in the setup method and pass it to the G-API framework by returning it. run method recieves additional state argument and user can handle state with this argument.
It is quite similar to the C++ stateful kernel API GAPI_OCV_KERNEL_ST and difference is setup method return state to the framework. This is the interface that I'd like to ask you to review ๐
[] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
-> No need for performance
The feature is well documented and sample code can be built with the project CMake
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review both interface design and code. ๐
Motivation
Stateful kernel in C++ is really useful to many usecases like tracking.
This PR will enable python G-API users to use stateful kernel and expand the usecases in python G-API.
Feature Design
Here is the example video and the example code of this feature.
The example kernel is like this.
Basically it create internal state in the
setup
method and pass it to the G-API framework by returning it.run
method recieves additionalstate
argument and user can handle state with this argument.It is quite similar to the C++ stateful kernel API
GAPI_OCV_KERNEL_ST
and difference is setup method return state to the framework. This is the interface that I'd like to ask you to review ๐How to run the demo code?
pip install numpy click
For video input.
For video file
TODO
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
-> No need for performance