| CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
G-API media format gray #21511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-API media format gray #21511
Conversation
|
@dbudniko please, add tests on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also extend gapi_frame_tests.cpp and, if inference works, gapi_infer_ie_test.cpp also?
| { | ||
| std::call_once(m_warnFlag, | ||
| []() { | ||
| GAPI_LOG_WARNING(NULL, "\nOn-the-fly conversion from GRAY to NV12 Y plane will " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning is not applicable here, if to be honest..
This accessor tries to return Y cv::Mat from any given frame. For GRAY frames it is enough to just return their data as Y planes. There is no expected time-consuming conversions.
Warning was about situation when we trying to access, for example, Y plane from BGR cv::MediaFrame. So, the conversion needs to be happen inside from BGR to NV12 and, then, Y plane can only be retrieved. As BGR input frame might have high enough resolution, conversion might be time-consuming and that is why warning is created.
So, here it might be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep a message here that requested plane here doesn't not quite align with the initial format
…/opencv into dbudniko/gapi_media_format_gray
|
3 new streaming tests with gray are OK now. |
|
Media Frame added and green now. Please review. We still have open regarding correct color conversion approach in streaming tests. Discussed it with Asya. Need your inputs to left one. #if0 #else #endif temporary left in the tests source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
|
@alalek please merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to discuss IE backend GRAY support last time
Please sorry for incoveniences!
|
@alalek gentle reminder |
…mat_gray G-API media format gray
…mat_gray G-API media format gray
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.