| CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Support queue capacity as graph compilation argument #20119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support queue capacity as graph compilation argument #20119
Conversation
|
@dmatveev Have a look, please |
| * fetch next frame while current is being processed. This compilation argument | ||
| * specifies the capacity of this queue. | ||
| */ | ||
| struct queue_capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenCV uses CamelCase for structures/classes/enum types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and so we do, but for some reason the graph compile arguments were started as snake_case (probably, unintentionally) so we follow it there now.
It is worth aligning in scope of 5.0 I believe.
| * fetch next frame while current is being processed. This compilation argument | ||
| * specifies the capacity of this queue. | ||
| */ | ||
| struct queue_capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and so we do, but for some reason the graph compile arguments were started as snake_case (probably, unintentionally) so we follow it there now.
It is worth aligning in scope of 5.0 I believe.
| struct GAPI_Streaming: public ::testing::TestWithParam<KernelPackage> { | ||
| GAPI_Streaming() { initTestDataPath(); } | ||
| struct GAPI_Streaming: public ::testing::TestWithParam<std::tuple<KernelPackage, | ||
| cv::optional<size_t>>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW optional doesn't print properly, It prints 0 if doesn't contain value.
I've tried to implement operator<< as for KernelPackage but it doesn't work :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just use compile_args? += should work for those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this compile_args should contain ? I guess queue_capacity and GKernelPackage.
But for SmokeTest_AutoMeta_VideoArray need to exclude GKernelPackage and use cv::gapi::kernels<TypesTest::OCVAddV>() instead
TolyaTalamanov
force-pushed
the
at/compile-arg-for-queue-capacity
branch
from
ca4d109 to
4c65c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead with merge. Thanks.
…r-queue-capacity * Support queue capacity as graph compilation argument * Fix comments to review * Fix comments to review * Fix comments to review
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.