CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
G-API MTCNN sample #19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-API MTCNN sample #19923
Conversation
@alalek I don't understand what is wrong with Ubuntu20 build. I see red error message "service under maintenance" or something like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it looks good already!
But team please review the kernel code more carefully, had no change to dig deep into that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superficially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some niggles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be more careful with the output. Most of my comments are suggestions for improvements and are not blocking the merge.
@alalek CI is green. 2 reviewers approved this PR. Can we merge it? |
…mo_PR G-API MTCNN sample * add face detection demo * clean up * enable back accumulate * additional input * meta args workaround * additional arg * add init * roll back * fix shadowing * roll back * clean up and PNet copy from debug branch which now works * try nets operator * more clean up * more clean up * add 6 layers pyramid experimental code * final clean up and ready for PR * original image resize * Remove Pnet declarations. Generic infer is used now. * scales and sizes calculation added * fix assert, and add ceil to size calculation * try doubles for scales * Address comments from Dmitry. * use half scale option * fix half scale * clean up debug outputs * try to get input image width and height * clean up * trailing spaces and review from Maxim * more comments from Maxim are addressed * try to fix warnings * try to fix warnings and address more comments from Dmitry * crop fix and clean up * more warnings fixes * more warnings fixes * more comments from Maxim are addressed * even more consts * copy_n for regressions * address more comments from Dmitry * more comments from Maxim
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.