You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
how should I handle this? all the existing code for every function is structured such that there is an extern C implementation of the respective function per toolkit, and then one namespaced wrapper function calling that.
I could remove the CV_IMPL (extern C) from all implementations of cvPollKey so it iself is not exposed. I think that will then require a forward declaration in window.cpp before/inside of cv::pollKey since the C function isn't declared in a common header anymore.
edit: that is... if CVAPI(int) cvPollKey(void); in highgui_c.h needs to go, I'll need to provide that declaration in some other way. maybe I misunderstand.
here are the requested changes. I hope I understood the intention.
I'll squash when you're satisfied with the state of the pull request and any discussion has resolved. squashing implies force-push; I hope that's correct.
This function's purpose is updating UI too (like waitKey())
I understand that. I'm not sure if waitKey should be given a more suitable name as well.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first code proposal for #19410
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.