CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Wrap cv::gapi::infer<Generic> into python #18491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3491564
to
8782991
Compare
8782991
to
cac31fe
Compare
e8ea54f
to
3cd12b4
Compare
3cd12b4
to
9755e84
Compare
Please rebase and fix warning from MSVS2019 |
@alalek Windows build are green |
modules/gapi/CMakeLists.txt
Outdated
@@ -32,6 +32,9 @@ if(MSVC) | |||
# Disable obsollete warning C4503 popping up on MSVC <<2017 | |||
# https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4503?view=vs-2019 | |||
ocv_warnings_disable(CMAKE_CXX_FLAGS /wd4503) | |||
# FIXME: Unreachable code in Params::backend() (ie.hpp) | |||
# https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4702?view=vs-2019 | |||
ocv_warnings_disable(CMAKE_CXX_FLAGS /wd4702) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ie.hpp
Disabling warnings here would not help users when they start building own applications with G-API public headers.
These settings are private for gapi module only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I was able to fix that warning in another header... maybe solution like that would work here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TolyaTalamanov Mentioned commit with workaround: 8637b7a
@@ -133,31 +133,35 @@ struct InOutInfo | |||
* @{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely a copy-paste issue, cc: @TolyaTalamanov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
[G-API] Wrap cv::gapi::infer<Generic> into python * Introduce generic infer * Move Generic to infer.hpp * Removew num_outs * Fix windows warnings * Fix comments to review * Fix doxygen * Add comment * Fix comments to review * Wrap inference to python * Add default ctor to Params * Add test * Fix clang build * Implement GInferInputs/GInferOutputs as Pimpl * Add checkIEtarget to infer test * Fix path * Supress warning * Use getAvailableDevices insted of checkIETarget * Move PyParams to bindings_ie * Add namespace * Update CMakeLists.txt
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
API example
Buildbot configuration