CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Move Aruco tutorials and samples to main repo #23018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
e9c6469
to
4f2bf71
Compare
4f2bf71
to
4fd7f36
Compare
ed660d5
to
bf8a61d
Compare
… images, refactoring docs, update snippets
bf8a61d
to
1378416
Compare
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
General comment: |
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
samples/cpp/tutorial_code/objectDetection/aruco_samples_utility.hpp
Outdated
Show resolved
Hide resolved
I propose to replace png images with jpg to reduce patch size. |
fixed |
The remaining PNG images are smaller than the JPG images. |
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
General notes:
|
doc/tutorials/objdetect/aruco_board_detection/aruco_board_detection.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Move Aruco tutorials and samples to main repo #3401 merge with opencv/opencv#23018 merge with merge with opencv/opencv_extra#1143 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Move Aruco tutorials and samples to main repo opencv#23018 merge with opencv/opencv_contrib#3401 merge with opencv/opencv_extra#1143 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake --------- Co-authored-by: AleksandrPanov <alexander.panov@xperience.ai> Co-authored-by: Alexander Smorkalov <alexander.smorkalov@xperience.ai>
merge with opencv/opencv_contrib#3401
merge with opencv/opencv_extra#1143
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.