build: simplify minifying script

danielroe · danielroe · commit dda8469531c9 · 2024-03-19T11:40:55.000Z
diff --git a/build.config.ts b/build.config.ts
@@ -1,10 +1,6 @@
 import { defineBuildConfig } from 'unbuild'
 
 export default defineBuildConfig({
-  // TODO: fix issue in unbuild with inlining package.json
-  // `Inlined implicit external D:\a\color-mode\color-mode\package.json`
-  failOnWarn: false,
-  entries: ['src/script'],
   hooks: {
     'rollup:options' (_ctx, options) {
       options.treeshake = false
diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "dist"
   ],
   "scripts": {
-    "prepack": "nuxt-module-build build && esbuild --minify dist/script.mjs --outfile=dist/script.min.js",
+    "prepack": "nuxt-module-build build && esbuild --minify src/script.js --outfile=dist/script.min.js",
     "build": "pnpm run prepack",
     "dev": "nuxi dev playground",
     "dev:build": "nuxi build playground",
diff --git a/src/script.js b/src/script.js
@@ -1,3 +1,5 @@
+// @ts-check
+
 // Add dark / light detection that runs before loading Nuxt
 (() => {
   // Global variable minimizers
@@ -16,7 +18,7 @@
 
   addColorScheme(value)
 
-  // @ts-ignore
+
   w['<%= options.globalName %>'] = {
     preference,
     value,
@@ -25,7 +27,7 @@
     removeColorScheme
   }
 
-  // @ts-ignore
+  /** @param {string} value */
   function addColorScheme (value) {
     const className = '<%= options.classPrefix %>' + value + '<%= options.classSuffix %>'
     const dataValue = '<%= options.dataValue %>'
@@ -39,7 +41,7 @@
     }
   }
 
-  // @ts-ignore
+  /** @param {string} value */
   function removeColorScheme (value) {
     const className = '<%= options.classPrefix %>' + value + '<%= options.classSuffix %>'
     const dataValue = '<%= options.dataValue %>'
@@ -53,14 +55,16 @@
     }
   }
 
-  // @ts-ignore
+  /** @param {string} suffix */
   function prefersColorScheme (suffix) {
     return w.matchMedia('(prefers-color-scheme' + suffix + ')')
   }
 
   function getColorScheme () {
-    // @ts-ignore
-    if (w.matchMedia && prefersColorScheme('').media !== 'not all') {
+    if (
+      // @ts-expect-error TS assumes matchMedia is always defined
+      w.matchMedia
+      && prefersColorScheme('').media !== 'not all') {
       for (const colorScheme of knownColorSchemes) {
         if (prefersColorScheme(':' + colorScheme).matches) {
           return colorScheme
diff --git a/src/script.min.js b/src/script.min.js
@@ -1 +1 @@
-script.ts
+script.js
