lifecycle: avoid building environment for empty lifecycle scripts

mikesherov · iarna · commit e0849878dd24 · 2017-06-26T16:17:56.000-07:00
Credit: @mikesherov Reviewed-By: @iarna PR-URL: npm/npm#17441
diff --git a/lib/utils/lifecycle.js b/lib/utils/lifecycle.js
@@ -60,6 +60,8 @@ function lifecycle (pkg, stage, wd, unsafe, failOk, cb) {
     delete pkg.scripts.prepublish
   }
 
+  if (!pkg.scripts[stage]) return cb()
+
   validWd(wd || path.resolve(npm.dir, pkg.name), function (er, wd) {
     if (er) return cb(er)
 

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,8 @@ function lifecycle (pkg, stage, wd, unsafe, failOk, cb) {`
`60`	`60`	`delete pkg.scripts.prepublish`
`61`	`61`	`}`
`62`	`62`
	`63`	`+ if (!pkg.scripts[stage]) return cb()`
	`64`	`+`
`63`	`65`	`validWd(wd \|\| path.resolve(npm.dir, pkg.name), function (er, wd) {`
`64`	`66`	`if (er) return cb(er)`
`65`	`67`