CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 05:15:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=361.861269,conversation_content-fragment;desc="conversation_content fragment";dur=943.035472,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=284.59903,nginx;desc="NGINX";dur=1.387661,glb;desc="GLB";dur=102.021729
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nwc3G2HP69WTec%2BYtJazszAyGFBgOHAPtSdBNh375fTomU5veHJOhtQjJI%2FASVUvuOeXECrJM%2Bb7Z1TXyIQN7VhOxchrmMRbRgLrILj2ORjluHjVscN0XhVf1y30xcrOeYpP9ycgn5SiEAATe%2FJuCMRebvEnk24AalCtKkMB180lRNO8g7CZhFfiLJ2nJMEl2T34eJ431Qn%2BRlCMUaD8o3ngdA2K2h4lfQgaloE1HJBZJpDw9Jwgd%2Bwx64Ja4XNa4vafS26hwJdeF7WahU8y7Q%3D%3D--rWf0jrDj2pCcpwFN--7ag%2BBsCsywFKPpD4g9KQWQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1554469914.1753247706; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 05:15:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 05:15:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 81E8:26221E:3E2782:53AE23:68806FDA
Introduce the ability of awaiting for eager beginning a Transaction by bigmontz · Pull Request #870 · neo4j/neo4j-javascript-driver · GitHub
bigmontz
force-pushed
the
5.0-implementing-eager-begin
branch
from
February 8, 2022 16:22
bigmontz
force-pushed
the
5.0-implementing-eager-begin
branch
2 times, most recently
from
February 9, 2022 11:20
bigmontz
force-pushed
the
5.0-implementing-eager-begin
branch
from
February 14, 2022 10:20
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 152
Introduce the ability of awaiting for eager beginning a Transaction #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0164c6
to
a90a7c0
Compare
Depends on: neo4j-drivers/testkit#397 |
7237267
to
ffe245e
Compare
fbiville
reviewed
Feb 10, 2022
fbiville
approved these changes
Feb 10, 2022
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
788a24e
to
9ec34af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The current implementation of
session.beginTransaction
does not wait the success message. This kind of behaviour can cause future calls torun
andcommit
because of non-reported errors during the begin.For solving this issue, the transaction object return by the
session.beginTransaction
was changed toTransactionPromise
. This new type holds all the behaviours from a Transaction and also holds the promise for the beginned transaction. This way, the caller can eagerly eager check the transaction begin and at the same type keep the API existing in the current codebase.Eager Mode:
Lazy Mode: