| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 07:25:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.887995,conversation_content-fragment;desc="conversation_content fragment";dur=757.696814,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=299.634844,nginx;desc="NGINX";dur=1.40765,glb;desc="GLB";dur=101.022691
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NoMFWC9kJoLERLMlG5QgAOXmY0NsqakU%2F6%2B5VApcB%2B7xGSjaN8%2B4cqbRl6UtRZmomRG0FyyTwEjnVtaiNUv%2B2QFa5BaBOpN%2B2aDqF9ZfAXkidoAd8whl%2BSR12ugK03WP3M1y6fWz9XARszsmTLPOg%2F23gXP%2FpAS%2FNFxqvpIBcyzkFZnz5sYSUYA%2BjsJgbeXBbItT6AcW5VLKhopG09Bdpr%2FIvU48HNAZ8Rdd25hIDZq%2BuwDR1KsKXShcqZF1Y4cuIpvRcLawgZEMYJKmpoZoHQ%3D%3D--k6o3hT4r8qv7X%2FpB--AeItyH9FogW2z2MCJwMC0w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1506668636.1753341925; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 07:25:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 07:25:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E596:18BEF9:5F6F30:782DA4:6881DFE5
Fail fast for more rediscovery failures by bigmontz · Pull Request #1011 · neo4j/neo4j-javascript-driver · GitHub
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
November 23, 2022 10:09
bigmontz
changed the title
Fail fast on rediscovery when 'Neo.ClientError.Statement.ArgumentError' failure
Fail fast for more rediscovery failures
Nov 24, 2022
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
December 6, 2022 12:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 152
Fail fast for more rediscovery failures #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
reviewed
Oct 27, 2022
packages/bolt-connection/src/connection-provider/connection-provider-routing.js
Outdated
Show resolved
Hide resolved
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
5d90636 to
bd5e8d9
Compare
bigmontz
changed the title
AndyHeap-NeoTech
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward enough. Approved.
robsdedude
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
|
Re-triggered the CI after the TestKit PR has been merged ⏳ |
…r' failure When trying to impersonate an invalid user, the routing procedure returns `Neo.ClientError.Statement.ArgumentError`. This type of failure is not in the fail fast list, thus this is wrapped up in the generic rediscovery error triggering the retry in the transaction functions. Since this kind of error is not recoverable, retrying on it is not need and desirable. Then, failing fast on `Neo.ClientError.Statement.ArgumentError` failures speeds up the error bubbling and avoids unnecessary load in the client and server.
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
23ee1bf to
1703009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When trying to impersonate an invalid user, the routing procedure returns
Neo.ClientError.Statement.ArgumentError. This type of failure is not in the fail fast list, thus this is wrapped up in the generic rediscovery error triggering the retry in the transaction functions. Since this kind of error is not recoverable, retrying on it is not need and desirable.Then, failing fast on
Neo.ClientError.Statement.ArgumentErrorfailures speeds up the error bubbling and avoids unnecessary load in the client and server.Other rediscovery failures to be fast failed are:
Neo.ClientError.Statement.TypeErrorNeo.ClientError.Request.Invalid