Merge pull request #1211 from neo4j/5.x-schema-notification-category

MaxAake · web-flow · commit c4e4c1cc01e0 · 2024-08-14T13:17:01.000+02:00
Add SCHEMA notification category
diff --git a/packages/core/src/notification-filter.ts b/packages/core/src/notification-filter.ts
@@ -40,7 +40,7 @@ Object.freeze(notificationFilterMinimumSeverityLevel)
 
 type NotificationFilterDisabledCategory = ExcludeUnknown<NotificationCategory>
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC'} NotificationFilterDisabledCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA'} NotificationFilterDisabledCategory
  */
 /**
  * Constants that represents the disabled categories in the {@link NotificationFilter}
@@ -53,7 +53,8 @@ const notificationFilterDisabledCategory: EnumRecord<NotificationFilterDisabledC
   TOPOLOGY: 'TOPOLOGY',
   SECURITY: 'SECURITY',
   DEPRECATION: 'DEPRECATION',
-  GENERIC: 'GENERIC'
+  GENERIC: 'GENERIC',
+  SCHEMA: 'SCHEMA'
 }
 Object.freeze(notificationFilterDisabledCategory)
 
diff --git a/packages/core/src/notification.ts b/packages/core/src/notification.ts
@@ -62,9 +62,9 @@ Object.freeze(notificationSeverityLevel)
 const severityLevels = Object.values(notificationSeverityLevel)
 
 type NotificationCategory = 'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' | 'PERFORMANCE' |
-'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
+'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA' | 'UNKNOWN'
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN' } NotificationCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA' | 'UNKNOWN' } NotificationCategory
  */
 /**
  * Constants that represents the Category in the {@link Notification}
@@ -78,6 +78,7 @@ const notificationCategory: { [key in NotificationCategory]: key } = {
   TOPOLOGY: 'TOPOLOGY',
   SECURITY: 'SECURITY',
   GENERIC: 'GENERIC',
+  SCHEMA: 'SCHEMA',
   UNKNOWN: 'UNKNOWN'
 }
 
diff --git a/packages/core/test/notification-filter.test.ts b/packages/core/test/notification-filter.test.ts
@@ -103,6 +103,7 @@ function getValidNotificationsCategories (): NotificationFilterDisabledCategory[
     'PERFORMANCE',
     'TOPOLOGY',
     'SECURITY',
+    'SCHEMA',
     'UNRECOGNIZED',
     'UNSUPPORTED'
   ]
diff --git a/packages/core/test/notification.test.ts b/packages/core/test/notification.test.ts
@@ -1393,6 +1393,7 @@ function getValidCategories (): NotificationCategory[] {
     'TOPOLOGY',
     'SECURITY',
     'DEPRECATION',
+    'SCHEMA',
     'GENERIC',
     'UNKNOWN'
   ]
@@ -1407,6 +1408,7 @@ function getValidClassifications (): NotificationClassification[] {
     'TOPOLOGY',
     'SECURITY',
     'DEPRECATION',
+    'SCHEMA',
     'GENERIC',
     'UNKNOWN'
   ]
diff --git a/packages/neo4j-driver-deno/lib/core/notification-filter.ts b/packages/neo4j-driver-deno/lib/core/notification-filter.ts
@@ -40,7 +40,7 @@ Object.freeze(notificationFilterMinimumSeverityLevel)
 
 type NotificationFilterDisabledCategory = ExcludeUnknown<NotificationCategory>
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC'} NotificationFilterDisabledCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA'} NotificationFilterDisabledCategory
  */
 /**
  * Constants that represents the disabled categories in the {@link NotificationFilter}
@@ -53,7 +53,8 @@ const notificationFilterDisabledCategory: EnumRecord<NotificationFilterDisabledC
   TOPOLOGY: 'TOPOLOGY',
   SECURITY: 'SECURITY',
   DEPRECATION: 'DEPRECATION',
-  GENERIC: 'GENERIC'
+  GENERIC: 'GENERIC',
+  SCHEMA: 'SCHEMA'
 }
 Object.freeze(notificationFilterDisabledCategory)
 
diff --git a/packages/neo4j-driver-deno/lib/core/notification.ts b/packages/neo4j-driver-deno/lib/core/notification.ts
@@ -62,9 +62,9 @@ Object.freeze(notificationSeverityLevel)
 const severityLevels = Object.values(notificationSeverityLevel)
 
 type NotificationCategory = 'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' | 'PERFORMANCE' |
-'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
+'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA' | 'UNKNOWN'
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN' } NotificationCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'SCHEMA' | 'UNKNOWN' } NotificationCategory
  */
 /**
  * Constants that represents the Category in the {@link Notification}
@@ -78,6 +78,7 @@ const notificationCategory: { [key in NotificationCategory]: key } = {
   TOPOLOGY: 'TOPOLOGY',
   SECURITY: 'SECURITY',
   GENERIC: 'GENERIC',
+  SCHEMA: 'SCHEMA',
   UNKNOWN: 'UNKNOWN'
 }
 
diff --git a/packages/neo4j-driver/test/types/index.test.ts b/packages/neo4j-driver/test/types/index.test.ts
@@ -149,6 +149,7 @@ const deprecationCategoryString: string = notificationCategory.DEPRECATION
 const performanceCategoryString: string = notificationCategory.PERFORMANCE
 const topologyCategoryString: string = notificationCategory.TOPOLOGY
 const securityCategoryString: string = notificationCategory.SECURITY
+const schemaCategoryString: string = notificationCategory.SCHEMA
 const genericCategoryString: string = notificationCategory.GENERIC
 const unrecognizedCategoryString: string = notificationCategory.UNRECOGNIZED
 const unsupportedCategoryString: string = notificationCategory.UNSUPPORTED
@@ -158,6 +159,7 @@ const deprecationCategory: NotificationCategory = notificationCategory.DEPRECATI
 const performanceCategory: NotificationCategory = notificationCategory.PERFORMANCE
 const topologyCategory: NotificationCategory = notificationCategory.TOPOLOGY
 const securityCategory: NotificationCategory = notificationCategory.SECURITY
+const schemaCategory: NotificationCategory = notificationCategory.SCHEMA
 const genericCategory: NotificationCategory = notificationCategory.GENERIC
 const unrecognizedCategory: NotificationCategory = notificationCategory.UNRECOGNIZED
 const unsupportedCategory: NotificationCategory = notificationCategory.UNSUPPORTED
@@ -168,6 +170,7 @@ const deprecationClassificationString: string = notificationClassification.DEPRE
 const performanceClassificationString: string = notificationClassification.PERFORMANCE
 const topologyClassificationString: string = notificationClassification.TOPOLOGY
 const securityClassificationString: string = notificationClassification.SECURITY
+const schemaClassificationString: string = notificationClassification.SCHEMA
 const genericClassificationString: string = notificationClassification.GENERIC
 const unrecognizedClassificationString: string = notificationClassification.UNRECOGNIZED
 const unsupportedClassificationString: string = notificationClassification.UNSUPPORTED
@@ -177,6 +180,7 @@ const deprecationClassification: NotificationClassification = notificationClassi
 const performanceClassification: NotificationClassification = notificationClassification.PERFORMANCE
 const topologyClassification: NotificationClassification = notificationClassification.TOPOLOGY
 const securityClassification: NotificationClassification = notificationClassification.SECURITY
+const schemaClassification: NotificationClassification = notificationClassification.SCHEMA
 const genericClassification: NotificationClassification = notificationClassification.GENERIC
 const unrecognizedClassification: NotificationClassification = notificationClassification.UNRECOGNIZED
 const unsupportedClassification: NotificationClassification = notificationClassification.UNSUPPORTED

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ function getValidNotificationsCategories (): NotificationFilterDisabledCategory[`
`103`	`103`	`'PERFORMANCE',`
`104`	`104`	`'TOPOLOGY',`
`105`	`105`	`'SECURITY',`
	`106`	`+ 'SCHEMA',`
`106`	`107`	`'UNRECOGNIZED',`
`107`	`108`	`'UNSUPPORTED'`
`108`	`109`	`]`