Remove deprecated ResultSummary.version (#867)

bigmontz · web-flow · commit 47ea9dfc90cf · 2022-02-08T12:20:42.000+01:00
diff --git a/packages/core/src/result-summary.ts b/packages/core/src/result-summary.ts
@@ -459,7 +459,6 @@ class Notification {
  */
 class ServerInfo {
   address?: string
-  version?: string
   protocolVersion?: number
   agent?: string
 
@@ -478,17 +477,6 @@ class ServerInfo {
        * @public
        */
       this.address = serverMeta.address
-      /**
-       * The server version string.
-       * 
-       * See {@link ServerInfo#protocolVersion} and {@link ServerInfo#agent}
-       * @type {string}
-       * @deprecated in 4.3, please use ServerInfo#agent, ServerInfo#protocolVersion, or call the <i>dbms.components</i> procedure instead.
-       * <b>Method might be removed in the next major release.</b>
-       
-       * @public
-       */
-      this.version = serverMeta.version
 
       /**
        * The server user agent string
diff --git a/packages/core/test/result-summary.test.ts b/packages/core/test/result-summary.test.ts
@@ -26,7 +26,6 @@ describe('ServerInfo', () => {
       4.3,
       {
         address: '192.168.0.1',
-        version: 'neo4j',
         protocolVersion: 4.3,
         agent: 'neo4j'
       }
@@ -36,7 +35,6 @@ describe('ServerInfo', () => {
       undefined,
       {
         address: '192.168.0.1',
-        version: 'neo4j',
         protocolVersion: undefined,
         agent: 'neo4j'
       }
diff --git a/packages/neo4j-driver/test/session.test.js b/packages/neo4j-driver/test/session.test.js
@@ -193,7 +193,7 @@ describe('#integration session', () => {
       const sum = result.summary
       expect(sum.server).toBeDefined()
       expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
-      expect(sum.server.version).toBeDefined()
+      expect(sum.server.version).toBeUndefined()
       done()
     })
   }, 70000)
diff --git a/packages/neo4j-driver/test/transaction.test.js b/packages/neo4j-driver/test/transaction.test.js
@@ -311,7 +311,7 @@ describe('#integration transaction', () => {
         const sum = result.summary
         expect(sum.server).toBeDefined()
         expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
-        expect(sum.server.version).toBeDefined()
+        expect(sum.server.version).toBeUndefined()
         tx.commit().then(done)
       })
       .catch(console.log)
@@ -331,8 +331,7 @@ describe('#integration transaction', () => {
 
         expect(server).toBeDefined()
         expect(server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
-        expect(server.version).toBeDefined()
-
+        expect(server.version).toBeUndefined()
         done()
       }
     })
diff --git a/packages/neo4j-driver/test/types/driver.test.ts b/packages/neo4j-driver/test/types/driver.test.ts
@@ -101,7 +101,6 @@ session1
 const close: Promise<void> = driver.close()
 
 driver.verifyConnectivity().then((serverInfo: ServerInfo) => {
-  console.log(serverInfo.version)
   console.log(serverInfo.address)
 })
 
diff --git a/packages/neo4j-driver/test/types/result-summary.test.ts b/packages/neo4j-driver/test/types/result-summary.test.ts
@@ -98,7 +98,6 @@ const column: number = position2.column
 
 const server: ServerInfo = sum1.server
 const address: string | undefined = server.address
-const version: string | undefined = server.version
 
 const resultConsumedAfter1: Integer = sum1.resultConsumedAfter
 const resultAvailableAfter1: Integer = sum1.resultAvailableAfter

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ describe('ServerInfo', () => {`
`26`	`26`	`4.3,`
`27`	`27`	`{`
`28`	`28`	`address: '192.168.0.1',`
`29`		`- version: 'neo4j',`
`30`	`29`	`protocolVersion: 4.3,`
`31`	`30`	`agent: 'neo4j'`
`32`	`31`	`}`
`@@ -36,7 +35,6 @@ describe('ServerInfo', () => {`
`36`	`35`	`undefined,`
`37`	`36`	`{`
`38`	`37`	`address: '192.168.0.1',`
`39`		`- version: 'neo4j',`
`40`	`38`	`protocolVersion: undefined,`
`41`	`39`	`agent: 'neo4j'`
`42`	`40`	`}`