Added Topology and Security Notification categories (#1146)

ConorNeo · web-flow · commit 360232156256 · 2023-10-10T12:21:16.000+02:00
I added Topology and Security notification categories to align with the new categories as of the 5.14 server.
diff --git a/packages/core/src/notification-filter.ts b/packages/core/src/notification-filter.ts
@@ -41,7 +41,7 @@ Object.freeze(notificationFilterMinimumSeverityLevel)
 
 type NotificationFilterDisabledCategory = ExcludeUnknown<NotificationCategory>
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'DEPRECATION' | 'GENERIC' } NotificationFilterDisabledCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC'} NotificationFilterDisabledCategory
  */
 /**
  * Constants that represents the disabled categories in the {@link NotificationFilter}
@@ -51,6 +51,8 @@ const notificationFilterDisabledCategory: EnumRecord<NotificationFilterDisabledC
   UNRECOGNIZED: 'UNRECOGNIZED',
   UNSUPPORTED: 'UNSUPPORTED',
   PERFORMANCE: 'PERFORMANCE',
+  TOPOLOGY: 'TOPOLOGY',
+  SECURITY: 'SECURITY',
   DEPRECATION: 'DEPRECATION',
   GENERIC: 'GENERIC'
 }
diff --git a/packages/core/src/result-summary.ts b/packages/core/src/result-summary.ts
@@ -436,9 +436,9 @@ Object.freeze(notificationSeverityLevel)
 const severityLevels = Object.values(notificationSeverityLevel)
 
 type NotificationCategory = 'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' | 'PERFORMANCE' |
-'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
+'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'} NotificationCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN' } NotificationCategory
  */
 /**
  * Constants that represents the Category in the {@link Notification}
@@ -449,6 +449,8 @@ const notificationCategory: { [key in NotificationCategory]: key } = {
   UNSUPPORTED: 'UNSUPPORTED',
   PERFORMANCE: 'PERFORMANCE',
   DEPRECATION: 'DEPRECATION',
+  TOPOLOGY: 'TOPOLOGY',
+  SECURITY: 'SECURITY',
   GENERIC: 'GENERIC',
   UNKNOWN: 'UNKNOWN'
 }
diff --git a/packages/core/test/notification-filter.test.ts b/packages/core/test/notification-filter.test.ts
@@ -77,6 +77,8 @@ function getValidNotificationsCategories (): NotificationFilterDisabledCategory[
     'DEPRECATION',
     'GENERIC',
     'PERFORMANCE',
+    'TOPOLOGY',
+    'SECURITY',
     'UNRECOGNIZED',
     'UNSUPPORTED'
   ]
diff --git a/packages/core/test/result-summary.test.ts b/packages/core/test/result-summary.test.ts
@@ -375,6 +375,8 @@ function getValidCategories (): NotificationCategory[] {
     'UNRECOGNIZED',
     'UNSUPPORTED',
     'PERFORMANCE',
+    'TOPOLOGY',
+    'SECURITY',
     'DEPRECATION',
     'GENERIC',
     'UNKNOWN'
diff --git a/packages/neo4j-driver-deno/lib/core/notification-filter.ts b/packages/neo4j-driver-deno/lib/core/notification-filter.ts
@@ -41,7 +41,7 @@ Object.freeze(notificationFilterMinimumSeverityLevel)
 
 type NotificationFilterDisabledCategory = ExcludeUnknown<NotificationCategory>
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'DEPRECATION' | 'GENERIC' } NotificationFilterDisabledCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC'} NotificationFilterDisabledCategory
  */
 /**
  * Constants that represents the disabled categories in the {@link NotificationFilter}
@@ -51,6 +51,8 @@ const notificationFilterDisabledCategory: EnumRecord<NotificationFilterDisabledC
   UNRECOGNIZED: 'UNRECOGNIZED',
   UNSUPPORTED: 'UNSUPPORTED',
   PERFORMANCE: 'PERFORMANCE',
+  TOPOLOGY: 'TOPOLOGY',
+  SECURITY: 'SECURITY',
   DEPRECATION: 'DEPRECATION',
   GENERIC: 'GENERIC'
 }
diff --git a/packages/neo4j-driver-deno/lib/core/result-summary.ts b/packages/neo4j-driver-deno/lib/core/result-summary.ts
@@ -436,9 +436,9 @@ Object.freeze(notificationSeverityLevel)
 const severityLevels = Object.values(notificationSeverityLevel)
 
 type NotificationCategory = 'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' | 'PERFORMANCE' |
-'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
+'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'
 /**
- * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN'} NotificationCategory
+ * @typedef {'HINT' | 'UNRECOGNIZED' | 'UNSUPPORTED' |'PERFORMANCE' | 'TOPOLOGY' | 'SECURITY' | 'DEPRECATION' | 'GENERIC' | 'UNKNOWN' } NotificationCategory
  */
 /**
  * Constants that represents the Category in the {@link Notification}
@@ -449,6 +449,8 @@ const notificationCategory: { [key in NotificationCategory]: key } = {
   UNSUPPORTED: 'UNSUPPORTED',
   PERFORMANCE: 'PERFORMANCE',
   DEPRECATION: 'DEPRECATION',
+  TOPOLOGY: 'TOPOLOGY',
+  SECURITY: 'SECURITY',
   GENERIC: 'GENERIC',
   UNKNOWN: 'UNKNOWN'
 }
diff --git a/packages/neo4j-driver/test/types/index.test.ts b/packages/neo4j-driver/test/types/index.test.ts
@@ -145,13 +145,17 @@ const informationSeverity: NotificationSeverityLevel = notificationSeverityLevel
 const hintCategoryString: string = notificationCategory.HINT
 const deprecationCategoryString: string = notificationCategory.DEPRECATION
 const performanceCategoryString: string = notificationCategory.PERFORMANCE
+const topologyCategoryString: string = notificationCategory.TOPOLOGY
+const securityCategoryString: string = notificationCategory.SECURITY
 const genericCategoryString: string = notificationCategory.GENERIC
 const unrecognizedCategoryString: string = notificationCategory.UNRECOGNIZED
 const unsupportedCategoryString: string = notificationCategory.UNSUPPORTED
 const unknownCategoryString: string = notificationCategory.UNKNOWN
 const hintCategory: NotificationCategory = notificationCategory.HINT
 const deprecationCategory: NotificationCategory = notificationCategory.DEPRECATION
 const performanceCategory: NotificationCategory = notificationCategory.PERFORMANCE
+const topologyCategory: NotificationCategory = notificationCategory.TOPOLOGY
+const securityCategory: NotificationCategory = notificationCategory.SECURITY
 const genericCategory: NotificationCategory = notificationCategory.GENERIC
 const unrecognizedCategory: NotificationCategory = notificationCategory.UNRECOGNIZED
 const unsupportedCategory: NotificationCategory = notificationCategory.UNSUPPORTED

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,8 @@ function getValidNotificationsCategories (): NotificationFilterDisabledCategory[`
`77`	`77`	`'DEPRECATION',`
`78`	`78`	`'GENERIC',`
`79`	`79`	`'PERFORMANCE',`
	`80`	`+ 'TOPOLOGY',`
	`81`	`+ 'SECURITY',`
`80`	`82`	`'UNRECOGNIZED',`
`81`	`83`	`'UNSUPPORTED'`
`82`	`84`	`]`