| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 18:13:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=334.25814,conversation_content-fragment;desc="conversation_content fragment";dur=728.360157,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=250.803829,nginx;desc="NGINX";dur=0.851377,glb;desc="GLB";dur=102.309281
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=OeCbcuT6fn31YD8CZYk7E4X2EzDPUBPrgkaoRD7ebsGaOYUPP0W%2BjHM1Dp8BvvVTB0zr5%2FNa336vNG6gBkXhT8i4io2YwXicvGlTNjJEUe9lfSzu4EBmi1BVhD0bml%2BmeLEZz8WS9FnVRv3tFFmj%2BO%2F4gjqTvyN%2FDw4AW4EyepBB%2BlMFEFPk98c1nISWBxNd9hCtcJFmgR70uM606ctWcyTJkqOLL17tyJtb0Ursshh6tiQbK%2FrQtxaQ1dNrI%2FkqeaD8J8CYvyj41pG%2FCF4fFQ%3D%3D--fVLuYRAR1ggGXxVa--kelq9%2BGwecxMjj7XBtGyiw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1545655146.1753726388; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 18:13:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 18:13:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9622:2D715E:D3CAB:FD4E9:6887BDB4
Avoid marking objects as both live and disposed by pontusmelke · Pull Request #178 · neo4j/neo4j-java-driver · GitHub
pontusmelke
force-pushed
the
1.0-thread-caching-bug
branch
3 times, most recently
from
May 26, 2016 08:41
pontusmelke
force-pushed
the
1.0-thread-caching-bug
branch
from
May 26, 2016 13:01
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 156
Avoid marking objects as both live and disposed #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontusmelke
force-pushed
the
1.0-thread-caching-bug
branch
3 times, most recently
from
a52f03b to
76dd71b
Compare
In the `ThreadCachingPool` whenever an object is picked from the `ThreadLocal` we cannot add it to the `disposed` queue directly since the object will already be present in the `live` queue (or will be on release). Doing that means that the object will be present both in the `live` and `disposed` queue and also means that on reallocation we can multiple copies of the same reference and can lead to that the `live` queue blows up in size.
pontusmelke
force-pushed
the
1.0-thread-caching-bug
branch
from
76dd71b to
246ebaa
Compare
Previously whenever an object was picked off the thread local cache it was added back to the live queue even thought it was never removed from there. This lead to indefinite growth of the live queue.
|
|
||
| //This is terrible hack, but I really want to keep the queues private in | ||
| //ThreadCachingPool | ||
| private static MethodHandle queueGetter( String name ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed :) This seems acceptable to me, since it's in a test - but it does smell, and it smells like a missing abstraction. If we find ourselves digging deeper into this hole, one thing we could explore is to make the queues in the pool into some sort of service, so the pool takes an "ItemStorageService" or something that exposes the domain methods the pool is using the queues for. Then the test can inject its own "counting item storage" or whatever.
Something something back in my day we never did hacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I found this code, https://github.com/neo4j/neo4j/commits/3.1/community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/utf8/SunMiscUTF8Encoder.java?author=jakewins, on teh internets and ran with it. Seemed legit.
|
I'll forward-merge to 1.1 as well |
pontusmelke
added a commit
to pontusmelke/neo4j-java-driver
that referenced
this pull request
Jun 9, 2016
pontusmelke
added a commit
that referenced
this pull request
Jun 9, 2016
Revert "Merge pull request #178 from pontusmelke/1.0-thread-caching-bug"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In the
ThreadCachingPoolwhenever an object is picked from theThreadLocalwe cannot add it to thedisposedqueue directly since theobject will already be present in the
livequeue (or will be on release). Doingthat means that the object will be present both in the
liveanddisposedqueue and also means that on reallocation we can multiple copies of the same
reference and can lead to that the
livequeue blows up in size.