| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 23:50:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=310.991233,conversation_content-fragment;desc="conversation_content fragment";dur=904.692249,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=276.737588,nginx;desc="NGINX";dur=0.512116,glb;desc="GLB";dur=101.442037
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=GY1k8B%2Fqf7nfRiJukdmuDdjhoZ%2BlWvnIyKkCsYGBdkhRE11jKiReKO1IhFvCzHJxxnliyKeJlK78VpBew%2BasU3wjxorhp%2BiFMvZc57o5GRsG2Dcli2QQMcS2z2ZRWuGzjr8Qs0eV4dI7%2FiYAhIWlOoeh0ZPg7Wrs894MUfrVlWAwo3b1s6%2BAWkPhSh2MHNVsYuMT6J23Wl6cGN27z1Iv0F7rRhMEfteCIA96NSBBIudEcT814h6YVDl%2F%2B9g8kNF6l%2BljIcyFXlgJX%2FUiEW%2Bfuw%3D%3D--eGqdjgtS7uJUPjj%2B--dqHpAhH61pX2gj0FZ%2BcBog%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1725823827.1753573805; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 910E:3C6DB4:1E476:30F23:688569AD
Port JSX type checking by ahejlsberg · Pull Request #762 · microsoft/typescript-go · GitHub
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
April 7, 2025 18:44
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 7, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 663
Port JSX type checking #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1733 out of 1738 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.symbols: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.types: Language not supported
- testdata/baselines/reference/submodule/compiler/booleanLiteralsContextuallyTypedFromUnion.types.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/callsOnComplexSignatures.js.diff: Language not supported
Comments suppressed due to low confidence (1)
internal/compiler/program.go:164
- Ensure that tspath.ExtensionTsx is included in tspath.SupportedJSExtensionsFlat (or handled separately) if TSX files are intended to be supported. Otherwise, TSX files may inadvertently be excluded from the unsupportedExtensions list.
if slices.Contains(tspath.SupportedJSExtensionsFlat, extension) {
jakebailey
approved these changes
Apr 7, 2025
|
Basically impossible to review this on any website at all, I was barely able to click approve 😄 The error baseline thing is fixed in #763. I also wish |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jakebailey
approved these changes
Apr 7, 2025
|
History in the making... thank you, @ahejlsberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
No description provided.