CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 11:56:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=359.739788,conversation_content-fragment;desc="conversation_content fragment";dur=700.73143,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=430.671907,nginx;desc="NGINX";dur=0.541399,glb;desc="GLB";dur=103.958383
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=bykbsodCeXPobwRMfRzYtSrb0JAWE8umaVSxcX9G45ffSGrW%2FoZn2hNQc9jjjdANj1pJJ9KeNH4ohTRSbeM28LteQslhzDfpwhrc5R2XPQ0sro20Yr29YKHWc7ldVBqHqivdNRDBHjzqUjkAWnsbtLJHfOBoKjUmJMeilZQW6DXMc4XCKEbLwulqxlDf%2BTq9rreoH51w24H91hA%2Fbr29IYV1t6o1HYtn50Ca9lYMDpNGYvTT2TY9V%2BA5oDgn8esDYHRopZxjrSeDa7qlpn1tUg%3D%3D--FNT%2BmWeCccCgS7xC--QVZ2%2BHE3xfRhY0l2P2UykQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.9696113.1753271771; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:56:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:56:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CDA:124FF4:ACA542:CEA4FF:6880CDDB
Add TS Server option to exclude files from auto-imports by andrewbranch · Pull Request #49578 · microsoft/TypeScript · GitHub
typescript-bot
added
Author: Team
For Milestone Bug
PRs that fix a bug with a specific milestone
labels
Jun 16, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Add TS Server option to exclude files from auto-imports #49578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+171
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
approved these changes
Jun 16, 2022
There might be some demand for file-level excludes: see date-fns/date-fns#3113 which could be alleviated by excluding |
5 tasks
It would be cool to include option for |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #35395
Adds a TS Server option (to be specified in
.vscode/settings.json
) calledautoImportFileExcludePatterns
. The format is identical to tsconfig.jsonexclude
specs, except I plan to do the following normalization on the VS Code side before sending to TS Server:*
will be prefixed with/
, e.g."**/node_modules/aws-sdk"
will become"/**/node_modules/aws-sdk"
"node_modules/aws-sdk"
) will be prefixed with/**/
to match any directory prefix.It’s also worth noting how this setting affects ambient modules and module augmentations (
autoImportFileExcludePatterns3.ts
in the tests). While the input to this setting refers to files, I’ve chosen to limit the granularity at which we filter to be per-module, not per-export. That means if more than one file declares an ambient module"foo"
, you can’t exclude the exports declared in just one of those files. We end up callinggetMergedSymbol
on these modules before looking at their individual exports, so we see all the exports from many files lumped together. (Keep in mind this setting does not exclude anything from your program, so excluded files in this setting still contribute to overall program knowledge.) If you wanted that kind of granularity, we’d have to look at the declarations of each export and evaluate the regexes against those rather than just doing it at the file level. With the right memoization, that might be possible, but I’d prefer to wait and see if there’s demand for it. As it is, to exclude an ambient module, the exclude patterns have to match every file that declares it, and its exports are either all included or all excluded.