You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save work by not checking timestamps or parsing the buildinfo file.
Retain correctness checks (like input file existence).
Suppress project status, which was confusing anyway.
The reason will be displayed to describe this comment to others. Learn more.
Not able to comment at location but you can put !force flag in addition here as well
// Check oldest output file name only if there is no missing output file nameif(!missingOutputFileName){// If the upstream project's newest file is older than our oldest output, we// can't be out of date because of itif(refStatus.newestInputFileTime&&refStatus.newestInputFileTime<=oldestOutputFileTime){continue;}// If the upstream project has only change .d.ts files, and we've built// *after* those files, then we're "psuedo up to date" and eligible for a fast rebuildif(refStatus.newestDeclarationFileContentChangedTime&&refStatus.newestDeclarationFileContentChangedTime<=oldestOutputFileTime){pseudoUpToDate=true;upstreamChangedProject=ref.path;continue;}// We have an output older than an upstream output - we are out of dateDebug.assert(oldestOutputFileName!==undefined,"Should have an oldest output filename here");return{type: UpToDateStatusType.OutOfDateWithUpstream,outOfDateOutputFileName: oldestOutputFileName,newerProjectName: ref.path};}
Not able to comment at location but you can put !force flag in addition here as well
// Check oldest output file name only if there is no missing output file nameif(!missingOutputFileName){// If the upstream project's newest file is older than our oldest output, we// can't be out of date because of itif(refStatus.newestInputFileTime&&refStatus.newestInputFileTime<=oldestOutputFileTime){continue;}// If the upstream project has only change .d.ts files, and we've built// *after* those files, then we're "psuedo up to date" and eligible for a fast rebuildif(refStatus.newestDeclarationFileContentChangedTime&&refStatus.newestDeclarationFileContentChangedTime<=oldestOutputFileTime){pseudoUpToDate=true;upstreamChangedProject=ref.path;continue;}// We have an output older than an upstream output - we are out of dateDebug.assert(oldestOutputFileName!==undefined,"Should have an oldest output filename here");return{type: UpToDateStatusType.OutOfDateWithUpstream,outOfDateOutputFileName: oldestOutputFileName,newerProjectName: ref.path};}
I expected that to be undefined since the previous !force check would prevent it from being set. Would you like me to add an assert?
Hmm for some reason i think it will be evaluated because missingOutputFileName is going to be undefined? as we are not doing those checks any more. assert would be nice if thats not the case
Hmm for some reason i think it will be evaluated because missingOutputFileName is going to be undefined? as we are not doing those checks any more. assert would be nice if thats not the case
I think this is your way of telling me I read it backwards. 😄
Edit: Turns out it wasn't asserting because oldestOutputFileTime was set to max-date so the if before the assert was true, causing it to be skipped. Obviously, checking explicitly is better.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save work by not checking timestamps or parsing the buildinfo file.
Retain correctness checks (like input file existence).
Suppress project status, which was confusing anyway.