| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 16:52:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=449.348169,conversation_content-fragment;desc="conversation_content fragment";dur=1107.201526,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=377.968127,nginx;desc="NGINX";dur=1.373686,glb;desc="GLB";dur=102.39867
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9%2FIPyll6OcErGsUO8u3uQOk2wMe1JKK7F%2BCiXuH8Ulkxnk6E3h7kvoWzMdL8WDjCbyg5A38wAZE0dYGCrqaKFjT5WfFcHXOUih28Bggp5IlZTcDfKaRepVDqOqGGIioAzezKDQEzWwISlIWzi2r4I2pgHVcO%2Fecmal%2BRz7C1R2Cyay96pVosxxrn6q%2FO36ihI9H0P5iPaDC0dk%2FnVvwQ7Flxtfz6LkcmuZqfeuQ700xhSzVrzoH178wA85lt7sXYqMaj3Ot0hftex%2FJIPqymzg%3D%3D--fhZqI23M7iC66We3--N67VnpbdCnKZ3ZXWIrQpqg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.262931254.1753289543; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 16:52:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 16:52:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BB58:35B563:ED8830:118CB37:68811347
Emit build info even on noEmitOnError or tsc --build by sheetalkamat · Pull Request #38853 · microsoft/TypeScript · GitHub
sheetalkamat
requested review from
weswigham,
RyanCavanaugh,
sandersn and
andrewbranch
June 1, 2020 19:50
sheetalkamat
force-pushed
the
noEmitOnError
branch
from
June 2, 2020 18:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Emit build info even on noEmitOnError or tsc --build #38853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
weswigham,
RyanCavanaugh,
sandersn and
andrewbranch
weswigham
approved these changes
Jun 1, 2020
.../watchMode/programUpdates/reportErrors/when-preserveWatchOutput-is-passed-on-command-line.js
Show resolved
Hide resolved
| ) { | ||
| const canEmitBuildInfo = !(buildResult & BuildResultFlags.SyntaxErrors) && program && !outFile(program.getCompilerOptions()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do syntax errors block a build info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there is nothing to write in this case. Only semantic errors are cached so there is no use writing tsbuildinfo in this case
sheetalkamat
force-pushed
the
noEmitOnError
branch
from
63b3ae4 to
7eeaf64
Compare
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 5, 2020
* upstream/master: (48 commits) Fix merging of JS value & TS type decl LEGO: check in for master to temporary branch. `getSymbolDisplayPartsDocumentationAndSymbolKind`: use actual `symbol.flags` for `getAliasedSymbol` LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Fix two tests Update user baselines LEGO: check in for master to temporary branch. address PR comments Emit build info even on noEmitOnError or tsc --build (microsoft#38853) Some changes to tsc baselines for clarity (microsoft#38850) LEGO: check in for master to temporary branch. fix merge conflicts polish tests remove outdated tests convert import trigger reason test convert import trigger reason only convert export trigger reason test convert export cursor only changes remove declaration ...
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
With this change the caching of semantic diagnostics in the builder is written to the disk with .tsbuildinfo so next incremental build should benefit from that.