CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 15:32:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=284.94396,conversation_content-fragment;desc="conversation_content fragment";dur=481.661946,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=244.844253,nginx;desc="NGINX";dur=0.724342,glb;desc="GLB";dur=100.710225
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=JLPLrO59ozs%2FiXQIZ2E8ab4MR%2FnmKdjKMVWwWrN5x%2FCrmc0xGQ0vKZXx6VE28wfpFwXYlg%2FfDP%2BdToaLEAtpc1EcXIfCqz8IOX2NKOZQL1MwMpLYGU%2BbhH1ROfnl07hN1HCRinU%2FdNAednNP3vJK4jJwgFk4aaiKSeHF%2FhPQe4tqyErOkCtA5N%2BwZXboyo%2BofAN%2BCLysdAyfBwKWh%2F219KGBmESwZh%2F7Fm5q9ioF95uOUBE1vSU%2Fh8%2FrVOuImc2915DwFmV4qPeu9vwganzpoQ%3D%3D--WG9rP07f%2FIyZPjXt--4XXdJ7SxGa%2BlevxvNVKR2g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1731342836.1753284731; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 15:32:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 15:32:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D356:D3350:E000B3:108C23B:6881007B
Improve 'bind' typing in --strictBindCallApply mode by ahejlsberg · Pull Request #28920 · microsoft/TypeScript · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Improve 'bind' typing in --strictBindCallApply mode #28920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DanielRosenwasser We should decided if we want to pull this into a point release or wait for 3.3. |
weswigham
approved these changes
Dec 10, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
With this PR we improve typing of the single-parameter
bind
method in--strictBindCallApply
mode such that generic functions and overloaded functions are more accurately typed (i.e. we improve typing of calls tobind
that bind justthis
and none of the function's parameters). Previously,bind
always erased type parameters and propagated only the last overload signature. Now, when calling the single-parameterbind
method on a function that has no explicitly declaredthis
parameter (which turns out to be >99% of all observed uses ofbind
), we simply propagate the function type itself, thus preserving generics and overloads.The PR introduces two new conditional types in
lib.d.ts
:ThisParameterType<T>
: Extracts the type of thethis
parameter ofT
, or 'unknown' ifT
has no 'this' parameter.OmitThisParameter<T>
: Removes the 'this' parameter fromT
. IfT
has no explicitly declaredthis
parameter, the result is simplyT
. Otherwise, a new function type with nothis
parameter is created fromT
. Generics are erased and only the last overload signature is propagated in this new function type.Fixes #28582.
Fixes #28900.