Disallow Infinity, -Infinity and NaN as an enum key name (#56161)

magic-akari · web-flow · commit ecc10241c89c · 2023-12-06T15:30:06.000-08:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -45022,7 +45022,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         }
         else {
             const text = getTextOfPropertyName(member.name);
-            if (isNumericLiteralName(text) && !isInfinityOrNaNString(text)) {
+            if (isNumericLiteralName(text)) {
                 error(member.name, Diagnostics.An_enum_member_cannot_have_a_numeric_name);
             }
         }
diff --git a/tests/baselines/reference/enumWithInfinityProperty.errors.txt b/tests/baselines/reference/enumWithInfinityProperty.errors.txt
@@ -0,0 +1,10 @@
+enumWithInfinityProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
+
+
+==== enumWithInfinityProperty.ts (1 errors) ====
+    enum A {
+        Infinity = 1
+        ~~~~~~~~
+!!! error TS2452: An enum member cannot have a numeric name.
+    }
+    
diff --git a/tests/baselines/reference/enumWithNaNProperty.errors.txt b/tests/baselines/reference/enumWithNaNProperty.errors.txt
@@ -0,0 +1,10 @@
+enumWithNaNProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
+
+
+==== enumWithNaNProperty.ts (1 errors) ====
+    enum A {
+        NaN = 1
+        ~~~
+!!! error TS2452: An enum member cannot have a numeric name.
+    }
+    
diff --git a/tests/baselines/reference/enumWithNegativeInfinityProperty.errors.txt b/tests/baselines/reference/enumWithNegativeInfinityProperty.errors.txt
@@ -0,0 +1,10 @@
+enumWithNegativeInfinityProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
+
+
+==== enumWithNegativeInfinityProperty.ts (1 errors) ====
+    enum A {
+        "-Infinity" = 1
+        ~~~~~~~~~~~
+!!! error TS2452: An enum member cannot have a numeric name.
+    }
+    

Original file line number	Diff line number	Diff line change
`@@ -45022,7 +45022,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`45022`	`45022`	`}`
`45023`	`45023`	`else {`
`45024`	`45024`	`const text = getTextOfPropertyName(member.name);`
`45025`		`- if (isNumericLiteralName(text) && !isInfinityOrNaNString(text)) {`
	`45025`	`+ if (isNumericLiteralName(text)) {`
`45026`	`45026`	`error(member.name, Diagnostics.An_enum_member_cannot_have_a_numeric_name);`
`45027`	`45027`	`}`
`45028`	`45028`	`}`