microsoft
diff --git a/‎src/compiler/checker.ts
Copy file name to clipboard
+45-25Lines changed: 45 additions & 25 deletions b/‎src/compiler/checker.ts
Copy file name to clipboard
+45-25Lines changed: 45 additions & 25 deletions
diff --git a/‎src/compiler/types.ts
Copy file name to clipboard
+36-4Lines changed: 36 additions & 4 deletions b/‎src/compiler/types.ts
Copy file name to clipboard
+36-4Lines changed: 36 additions & 4 deletions
diff --git a/‎src/compiler/utilities.ts
Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions b/‎src/compiler/utilities.ts
Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions
diff --git a/‎src/harness/client.ts
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion b/‎src/harness/client.ts
Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/harness/fourslashImpl.ts
Copy file name to clipboard
+7-2Lines changed: 7 additions & 2 deletions b/‎src/harness/fourslashImpl.ts
Copy file name to clipboard
+7-2Lines changed: 7 additions & 2 deletions
diff --git a/‎src/harness/fourslashInterfaceImpl.ts
Copy file name to clipboard
+2-2Lines changed: 2 additions & 2 deletions b/‎src/harness/fourslashInterfaceImpl.ts
Copy file name to clipboard
+2-2Lines changed: 2 additions & 2 deletions
diff --git a/‎src/server/session.ts
Copy file name to clipboard
+8-2Lines changed: 8 additions & 2 deletions b/‎src/server/session.ts
Copy file name to clipboard
+8-2Lines changed: 8 additions & 2 deletions
diff --git a/‎src/services/services.ts
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion b/‎src/services/services.ts
Copy file name to clipboard
+3-1Lines changed: 3 additions & 1 deletion
diff --git a/‎src/services/symbolDisplay.ts
Copy file name to clipboard
+22-4Lines changed: 22 additions & 4 deletions b/‎src/services/symbolDisplay.ts
Copy file name to clipboard
+22-4Lines changed: 22 additions & 4 deletions
diff --git a/‎src/services/types.ts
Copy file name to clipboard
+3-2Lines changed: 3 additions & 2 deletions b/‎src/services/types.ts
Copy file name to clipboard
+3-2Lines changed: 3 additions & 2 deletions
@@ -5143,7 +5143,16 @@ export interface TypeChecker {
     symbolToParameterDeclaration(symbol: Symbol, enclosingDeclaration: Node | undefined, flags: NodeBuilderFlags | undefined): ParameterDeclaration | undefined;
     /** Note that the resulting nodes cannot be checked. */
     typeParameterToDeclaration(parameter: TypeParameter, enclosingDeclaration: Node | undefined, flags: NodeBuilderFlags | undefined): TypeParameterDeclaration | undefined;
-    /** @internal */ typeParameterToDeclaration(parameter: TypeParameter, enclosingDeclaration: Node | undefined, flags: NodeBuilderFlags | undefined, internalFlags?: InternalNodeBuilderFlags, tracker?: SymbolTracker, verbosityLevel?: number, out?: WriterContextOut): TypeParameterDeclaration | undefined; // eslint-disable-line @typescript-eslint/unified-signatures
+    /** @internal */ typeParameterToDeclaration(
+        parameter: TypeParameter,
+        enclosingDeclaration: Node | undefined,
+        flags: NodeBuilderFlags | undefined,
+        internalFlags?: InternalNodeBuilderFlags,
+        tracker?: SymbolTracker,
+        maximumLength?: number,
+        verbosityLevel?: number,
+        out?: WriterContextOut, // eslint-disable-line @typescript-eslint/unified-signatures
+    ): TypeParameterDeclaration | undefined;
 
     getSymbolsInScope(location: Node, meaning: SymbolFlags): Symbol[];
     getSymbolAtLocation(node: Node): Symbol | undefined;
@@ -5175,8 +5184,25 @@ export interface TypeChecker {
     symbolToString(symbol: Symbol, enclosingDeclaration?: Node, meaning?: SymbolFlags, flags?: SymbolFormatFlags): string;
     typePredicateToString(predicate: TypePredicate, enclosingDeclaration?: Node, flags?: TypeFormatFlags): string;
 
-    /** @internal */ writeSignature(signature: Signature, enclosingDeclaration?: Node, flags?: TypeFormatFlags, kind?: SignatureKind, writer?: EmitTextWriter, verbosityLevel?: number, out?: WriterContextOut): string;
-    /** @internal */ writeType(type: Type, enclosingDeclaration?: Node, flags?: TypeFormatFlags, writer?: EmitTextWriter, verbosityLevel?: number, out?: WriterContextOut): string;
+    /** @internal */ writeSignature(
+        signature: Signature,
+        enclosingDeclaration?: Node,
+        flags?: TypeFormatFlags,
+        kind?: SignatureKind,
+        writer?: EmitTextWriter,
+        maximumLength?: number,
+        verbosityLevel?: number,
+        out?: WriterContextOut,
+    ): string;
+    /** @internal */ writeType(
+        type: Type,
+        enclosingDeclaration?: Node,
+        flags?: TypeFormatFlags,
+        writer?: EmitTextWriter,
+        maximumLength?: number,
+        verbosityLevel?: number,
+        out?: WriterContextOut,
+    ): string;
     /** @internal */ writeSymbol(symbol: Symbol, enclosingDeclaration?: Node, meaning?: SymbolFlags, flags?: SymbolFormatFlags, writer?: EmitTextWriter): string;
     /** @internal */ writeTypePredicate(predicate: TypePredicate, enclosingDeclaration?: Node, flags?: TypeFormatFlags, writer?: EmitTextWriter): string;
 
@@ -5896,7 +5922,7 @@ export interface EmitResolver {
     isImportRequiredByAugmentation(decl: ImportDeclaration): boolean;
     isDefinitelyReferenceToGlobalSymbolObject(node: Node): boolean;
     createLateBoundIndexSignatures(cls: ClassLikeDeclaration, enclosingDeclaration: Node, flags: NodeBuilderFlags, internalFlags: InternalNodeBuilderFlags, tracker: SymbolTracker): (IndexSignatureDeclaration | PropertyDeclaration)[] | undefined;
-    symbolToDeclarations(symbol: Symbol, meaning: SymbolFlags, flags: NodeBuilderFlags, verbosityLevel?: number, out?: WriterContextOut): Declaration[];
+    symbolToDeclarations(symbol: Symbol, meaning: SymbolFlags, flags: NodeBuilderFlags, maximumLength?: number, verbosityLevel?: number, out?: WriterContextOut): Declaration[];
 }
 
 // dprint-ignore
@@ -10517,6 +10543,12 @@ export interface UserPreferences {
     readonly displayPartsForJSDoc?: boolean;
     readonly generateReturnInDocTemplate?: boolean;
     readonly disableLineTextInReferences?: boolean;
+    /**
+     * A positive integer indicating the maximum length of a hover text before it is truncated.
+     *
+     * Default: `500`
+     */
+    readonly maximumHoverLength?: number;
 }
 
 export type OrganizeImportsTypeOrder = "last" | "inline" | "first";
 
@@ -614,6 +614,8 @@ export const externalHelpersModuleNameText = "tslib";
 export const defaultMaximumTruncationLength = 160;
 /** @internal */
 export const noTruncationMaximumTruncationLength = 1_000_000;
+/** @internal */
+export const defaultHoverMaximumTruncationLength = 500;
 
 /** @internal */
 export function getDeclarationOfKind<T extends Declaration>(symbol: Symbol, kind: T["kind"]): T | undefined {
 
@@ -254,7 +254,7 @@ export class SessionClient implements LanguageService {
         return { line, character: offset };
     }
 
-    getQuickInfoAtPosition(fileName: string, position: number, verbosityLevel?: number | undefined): QuickInfo {
+    getQuickInfoAtPosition(fileName: string, position: number, maximumLength?: number, verbosityLevel?: number | undefined): QuickInfo {
         const args = { ...this.createFileLocationRequestArgs(fileName, position), verbosityLevel };
 
         const request = this.processRequest<protocol.QuickInfoRequest>(protocol.CommandTypes.Quickinfo, args);
 
@@ -2455,11 +2455,16 @@ export class TestState {
         return result;
     }
 
-    public baselineQuickInfo(verbosityLevels?: VerbosityLevels): void {
+    public baselineQuickInfo(verbosityLevels?: VerbosityLevels, maximumLength?: number): void {
         const result = ts.arrayFrom(this.testData.markerPositions.entries(), ([name, marker]) => {
             const verbosityLevel = toArray(verbosityLevels?.[name]);
             const items = verbosityLevel.map(verbosityLevel => {
-                const item: ts.QuickInfo & { verbosityLevel?: number; } | undefined = this.languageService.getQuickInfoAtPosition(marker.fileName, marker.position, verbosityLevel);
+                const item: ts.QuickInfo & { verbosityLevel?: number; } | undefined = this.languageService.getQuickInfoAtPosition(
+                    marker.fileName,
+                    marker.position,
+                    maximumLength,
+                    verbosityLevel,
+                );
                 if (item) item.verbosityLevel = verbosityLevel;
                 return {
                     marker: { ...marker, name },
 
@@ -449,8 +449,8 @@ export class Verify extends VerifyNegatable {
         this.state.baselineGetEmitOutput();
     }
 
-    public baselineQuickInfo(verbosityLevels?: FourSlash.VerbosityLevels): void {
-        this.state.baselineQuickInfo(verbosityLevels);
+    public baselineQuickInfo(verbosityLevels?: FourSlash.VerbosityLevels, maximumLength?: number): void {
+        this.state.baselineQuickInfo(verbosityLevels, maximumLength);
     }
 
     public baselineSignatureHelp(): void {
 
@@ -2395,12 +2395,18 @@ export class Session<TMessage = string> implements EventSender {
     private getQuickInfoWorker(args: protocol.QuickInfoRequestArgs, simplifiedResult: boolean): protocol.QuickInfoResponseBody | QuickInfo | undefined {
         const { file, project } = this.getFileAndProject(args);
         const scriptInfo = this.projectService.getScriptInfoForNormalizedPath(file)!;
-        const quickInfo = project.getLanguageService().getQuickInfoAtPosition(file, this.getPosition(args, scriptInfo), args.verbosityLevel);
+        const userPreferences = this.getPreferences(file);
+        const quickInfo = project.getLanguageService().getQuickInfoAtPosition(
+            file,
+            this.getPosition(args, scriptInfo),
+            userPreferences.maximumHoverLength,
+            args.verbosityLevel,
+        );
         if (!quickInfo) {
             return undefined;
         }
 
-        const useDisplayParts = !!this.getPreferences(file).displayPartsForJSDoc;
+        const useDisplayParts = !!userPreferences.displayPartsForJSDoc;
         if (simplifiedResult) {
             const displayString = displayPartsToString(quickInfo.displayParts);
             return {
 
@@ -49,6 +49,7 @@ import {
     Debug,
     Declaration,
     deduplicate,
+    defaultHoverMaximumTruncationLength,
     DefinitionInfo,
     DefinitionInfoAndBoundSpan,
     Diagnostic,
@@ -2274,7 +2275,7 @@ export function createLanguageService(
         return Completions.getCompletionEntrySymbol(program, log, getValidSourceFile(fileName), position, { name, source }, host, preferences);
     }
 
-    function getQuickInfoAtPosition(fileName: string, position: number, verbosityLevel?: number): QuickInfo | undefined {
+    function getQuickInfoAtPosition(fileName: string, position: number, maximumLength?: number, verbosityLevel?: number): QuickInfo | undefined {
         synchronizeHostData();
 
         const sourceFile = getValidSourceFile(fileName);
@@ -2310,6 +2311,7 @@ export function createLanguageService(
                     nodeForQuickInfo,
                     /*semanticMeaning*/ undefined,
                     /*alias*/ undefined,
+                    maximumLength ?? defaultHoverMaximumTruncationLength,
                     verbosityLevel,
                 ),
         );
 
@@ -266,6 +266,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
     type: Type | undefined,
     semanticMeaning: SemanticMeaning,
     alias?: Symbol,
+    maximumLength?: number,
     verbosityLevel?: number,
 ): SymbolDisplayPartsDocumentationAndSymbolKind {
     const displayParts: SymbolDisplayPart[] = [];
@@ -495,6 +496,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                 location.parent && isConstTypeReference(location.parent) ? typeChecker.getTypeAtLocation(location.parent) : typeChecker.getDeclaredTypeOfSymbol(symbol),
                 enclosingDeclaration,
                 TypeFormatFlags.InTypeAlias,
+                maximumLength,
                 verbosityLevel,
                 typeWriterOut,
             ),
@@ -602,6 +604,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                         type,
                         semanticMeaning,
                         shouldUseAliasName ? symbol : resolvedSymbol,
+                        maximumLength,
                         verbosityLevel,
                     );
                     displayParts.push(...resolvedInfo.displayParts);
@@ -700,11 +703,12 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                                 symbolDisplayNodeBuilderFlags,
                                 /*internalFlags*/ undefined,
                                 /*tracker*/ undefined,
+                                maximumLength,
                                 verbosityLevel,
                                 typeWriterOut,
                             )!;
                             getPrinter().writeNode(EmitHint.Unspecified, param, getSourceFileOfNode(getParseTreeNode(enclosingDeclaration)), writer);
-                        });
+                        }, maximumLength);
                         addRange(displayParts, typeParameterParts);
                     }
                     else {
@@ -715,6 +719,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                                 type,
                                 enclosingDeclaration,
                                 /*flags*/ undefined,
+                                maximumLength,
                                 verbosityLevel,
                                 typeWriterOut,
                             ),
@@ -889,6 +894,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                     symbol,
                     symbolMeaning,
                     TypeFormatFlags.MultilineObjectLiterals | TypeFormatFlags.UseAliasDefinedOutsideCurrentScope,
+                    maximumLength,
                     verbosityLevel !== undefined ? verbosityLevel - 1 : undefined,
                     typeWriterOut,
                 );
@@ -898,7 +904,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
                     if (i > 0) writer.writeLine();
                     printer.writeNode(EmitHint.Unspecified, node, sourceFile, writer);
                 });
-            });
+            }, maximumLength);
             addRange(displayParts, expandedDisplayParts);
             symbolWasExpanded = true;
             return true;
@@ -973,7 +979,7 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
     }
 
     function addSignatureDisplayParts(signature: Signature, allSignatures: readonly Signature[], flags = TypeFormatFlags.None) {
-        addRange(displayParts, signatureToDisplayParts(typeChecker, signature, enclosingDeclaration, flags | TypeFormatFlags.WriteTypeArgumentsOfSignature, verbosityLevel, typeWriterOut));
+        addRange(displayParts, signatureToDisplayParts(typeChecker, signature, enclosingDeclaration, flags | TypeFormatFlags.WriteTypeArgumentsOfSignature, maximumLength, verbosityLevel, typeWriterOut));
         if (allSignatures.length > 1) {
             displayParts.push(spacePart());
             displayParts.push(punctuationPart(SyntaxKind.OpenParenToken));
@@ -1011,9 +1017,21 @@ export function getSymbolDisplayPartsDocumentationAndSymbolKind(
     location: Node,
     semanticMeaning: SemanticMeaning = getMeaningFromLocation(location),
     alias?: Symbol,
+    maximumLength?: number,
     verbosityLevel?: number,
 ): SymbolDisplayPartsDocumentationAndSymbolKind {
-    return getSymbolDisplayPartsDocumentationAndSymbolKindWorker(typeChecker, symbol, sourceFile, enclosingDeclaration, location, /*type*/ undefined, semanticMeaning, alias, verbosityLevel);
+    return getSymbolDisplayPartsDocumentationAndSymbolKindWorker(
+        typeChecker,
+        symbol,
+        sourceFile,
+        enclosingDeclaration,
+        location,
+        /*type*/ undefined,
+        semanticMeaning,
+        alias,
+        maximumLength,
+        verbosityLevel,
+    );
 }
 
 function isLocalVariableOrFunction(symbol: Symbol) {
 
@@ -581,10 +581,11 @@ export interface LanguageService {
      *
      * @param fileName The path to the file
      * @param position A zero-based index of the character where you want the quick info
+     * @param maximumLength Maximum length of a quickinfo text before it is truncated.
      */
-    getQuickInfoAtPosition(fileName: string, position: number): QuickInfo | undefined;
+    getQuickInfoAtPosition(fileName: string, position: number, maximumLength?: number): QuickInfo | undefined;
     /** @internal */
-    getQuickInfoAtPosition(fileName: string, position: number, verbosityLevel: number | undefined): QuickInfo | undefined; // eslint-disable-line @typescript-eslint/unified-signatures
+    getQuickInfoAtPosition(fileName: string, position: number, maximumLength: number | undefined, verbosityLevel: number | undefined): QuickInfo | undefined;
 
     getNameOrDottedNameSpan(fileName: string, startPos: number, endPos: number): TextSpan | undefined;
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ export class SessionClient implements LanguageService {`
`254`	`254`	`return { line, character: offset };`
`255`	`255`	`}`
`256`	`256`
`257`		`- getQuickInfoAtPosition(fileName: string, position: number, verbosityLevel?: number \| undefined): QuickInfo {`
	`257`	`+ getQuickInfoAtPosition(fileName: string, position: number, maximumLength?: number, verbosityLevel?: number \| undefined): QuickInfo {`
`258`	`258`	`const args = { ...this.createFileLocationRequestArgs(fileName, position), verbosityLevel };`
`259`	`259`
`260`	`260`	`const request = this.processRequest<protocol.QuickInfoRequest>(protocol.CommandTypes.Quickinfo, args);`
Original file line number	Diff line number	Diff line change
`@@ -449,8 +449,8 @@ export class Verify extends VerifyNegatable {`
`449`	`449`	`this.state.baselineGetEmitOutput();`
`450`	`450`	`}`
`451`	`451`
`452`		`- public baselineQuickInfo(verbosityLevels?: FourSlash.VerbosityLevels): void {`
`453`		`- this.state.baselineQuickInfo(verbosityLevels);`
	`452`	`+ public baselineQuickInfo(verbosityLevels?: FourSlash.VerbosityLevels, maximumLength?: number): void {`
	`453`	`+ this.state.baselineQuickInfo(verbosityLevels, maximumLength);`
`454`	`454`	`}`
`455`	`455`
`456`	`456`	`public baselineSignatureHelp(): void {`