microsoft
diff --git a/‎.gitignore
Copy file name to clipboard
-3Lines changed: 0 additions & 3 deletions b/‎.gitignore
Copy file name to clipboard
-3Lines changed: 0 additions & 3 deletions
diff --git a/‎GitHubConfiguration.ps1
Copy file name to clipboard
-9Lines changed: 0 additions & 9 deletions b/‎GitHubConfiguration.ps1
Copy file name to clipboard
-9Lines changed: 0 additions & 9 deletions
diff --git a/‎GitHubCore.ps1
Copy file name to clipboard
+10-12Lines changed: 10 additions & 12 deletions b/‎GitHubCore.ps1
Copy file name to clipboard
+10-12Lines changed: 10 additions & 12 deletions
diff --git a/‎GitHubIssues.ps1
Copy file name to clipboard
+13-8Lines changed: 13 additions & 8 deletions b/‎GitHubIssues.ps1
Copy file name to clipboard
+13-8Lines changed: 13 additions & 8 deletions
@@ -1,4 +1 @@
 Tests/Config/Settings.ps1
-Microsoft.ApplicationInsights.dll
-Microsoft.Diagnostics.Tracing.EventSource.dll
-Microsoft.Threading.Tasks.dll
@@ -76,11 +76,6 @@ function Set-GitHubConfiguration
         Change the Application Insights instance that telemetry will be reported to (if telemetry
         hasn't been disabled via DisableTelemetry).
 
-    .PARAMETER AssemblyPath
-        The location that any dependent assemblies that this module depends on can be located.
-        If the assemblies can't be found at this location, nor in a temporary cache or in
-        the module's directory, the assemblies will be downloaded and temporarily cached.
-
     .PARAMETER DefaultNoStatus
         Control if the -NoStatus switch should be passed-in by default to all methods.
 
@@ -182,8 +177,6 @@ function Set-GitHubConfiguration
 
         [string] $ApplicationInsightsKey,
 
-        [string] $AssemblyPath,
-
         [switch] $DefaultNoStatus,
 
         [string] $DefaultOwnerName,
@@ -279,7 +272,6 @@ function Get-GitHubConfiguration
         [ValidateSet(
             'ApiHostName',
             'ApplicationInsightsKey',
-            'AssemblyPath',
             'DefaultNoStatus',
             'DefaultOwnerName',
             'DefaultRepositoryName',
@@ -617,7 +609,6 @@ function Import-GitHubConfiguration
     $config = [PSCustomObject]@{
         'apiHostName' = 'github.com'
         'applicationInsightsKey' = '66d83c52-3070-489b-886b-09860e05e78a'
-        'assemblyPath' = [String]::Empty
         'disableLogging' = ([String]::IsNullOrEmpty($logPath))
         'disablePiiProtection' = $false
         'disableSmarterObjects' = $false
 
@@ -98,8 +98,7 @@ function Invoke-GHRestMethod
 
     .NOTES
         This wraps Invoke-WebRequest as opposed to Invoke-RestMethod because we want access to the headers
-        that are returned in the response (specifically 'MS-ClientRequestId') for logging purposes, and
-        Invoke-RestMethod drops those headers.
+        that are returned in the response, and Invoke-RestMethod drops those headers.
 #>
     [CmdletBinding(SupportsShouldProcess)]
     param(
@@ -144,10 +143,7 @@ function Invoke-GHRestMethod
 
     # Telemetry-related
     $stopwatch = New-Object -TypeName System.Diagnostics.Stopwatch
-    $localTelemetryProperties = @{
-        'UriFragment' = $UriFragment
-        'WaitForCompletion' = ($WaitForCompletion -eq $true)
-    }
+    $localTelemetryProperties = @{}
     $TelemetryProperties.Keys | ForEach-Object { $localTelemetryProperties[$_] = $TelemetryProperties[$_] }
     $errorBucket = $TelemetryExceptionBucket
     if ([String]::IsNullOrEmpty($errorBucket))
@@ -198,13 +194,14 @@ function Invoke-GHRestMethod
         return
     }
 
+    $NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus
+
     try
     {
         Write-Log -Message $Description -Level Verbose
         Write-Log -Message "Accessing [$Method] $url [Timeout = $(Get-GitHubConfiguration -Name WebRequestTimeoutSec))]" -Level Verbose
 
         $result = $null
-        $NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus
         if ($NoStatus)
         {
             $params = @{}
@@ -293,7 +290,8 @@ function Invoke-GHRestMethod
                         Write-Log -Message "Unable to retrieve the raw HTTP Web Response:" -Exception $_ -Level Warning
                     }
 
-                    throw (ConvertTo-Json -InputObject $ex -Depth 20)
+                    $jsonConversionDepth = 20 # Seems like it should be more than sufficient
+                    throw (ConvertTo-Json -InputObject $ex -Depth $jsonConversionDepth)
                 }
             }
 
@@ -326,7 +324,7 @@ function Invoke-GHRestMethod
         if (-not [String]::IsNullOrEmpty($TelemetryEventName))
         {
             $telemetryMetrics = @{ 'Duration' = $stopwatch.Elapsed.TotalSeconds }
-            Set-TelemetryEvent -EventName $TelemetryEventName -Properties $localTelemetryProperties -Metrics $telemetryMetrics
+            Set-TelemetryEvent -EventName $TelemetryEventName -Properties $localTelemetryProperties -Metrics $telemetryMetrics -NoStatus:$NoStatus
         }
 
         $finalResult = $result.Content
@@ -454,14 +452,14 @@ function Invoke-GHRestMethod
             {
                 # Will be thrown if $ex.Message isn't JSON content
                 Write-Log -Exception $_ -Level Error
-                Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties
+                Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus
                 throw
             }
         }
         else
         {
             Write-Log -Exception $_ -Level Error
-            Set-TelemetryException -Exception $_.Exception -ErrorBucket $errorBucket -Properties $localTelemetryProperties
+            Set-TelemetryException -Exception $_.Exception -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus
             throw
         }
 
@@ -524,7 +522,7 @@ function Invoke-GHRestMethod
 
         $newLineOutput = ($output -join [Environment]::NewLine)
         Write-Log -Message $newLineOutput -Level Error
-        Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties
+        Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus
         throw $newLineOutput
     }
 }
 
@@ -322,16 +322,21 @@ function Get-GitHubIssue
         'NoStatus' = (Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus)
     }
 
-    $result = Invoke-GHRestMethodMultipleResult @params
-
-    if ($IgnorePullRequests)
+    try
     {
-        return ($result | Where-Object { $null -eq (Get-Member -InputObject $_ -Name pull_request) })
-    }
-    else
-    {
-        return $result
+        $result = Invoke-GHRestMethodMultipleResult @params
+
+        if ($IgnorePullRequests)
+        {
+            return ($result | Where-Object { $null -eq (Get-Member -InputObject $_ -Name pull_request) })
+        }
+        else
+        {
+            return $result
+        }
+
     }
+    finally {}
 }
 
 function Get-GitHubIssueTimeline
Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,7 @@ function Invoke-GHRestMethod`
`98`	`98`
`99`	`99`	`.NOTES`
`100`	`100`	`This wraps Invoke-WebRequest as opposed to Invoke-RestMethod because we want access to the headers`
`101`		`- that are returned in the response (specifically 'MS-ClientRequestId') for logging purposes, and`
`102`		`- Invoke-RestMethod drops those headers.`
	`101`	`+ that are returned in the response, and Invoke-RestMethod drops those headers.`
`103`	`102`	`#>`
`104`	`103`	`[CmdletBinding(SupportsShouldProcess)]`
`105`	`104`	`param(`
`@@ -144,10 +143,7 @@ function Invoke-GHRestMethod`
`144`	`143`
`145`	`144`	`# Telemetry-related`
`146`	`145`	`$stopwatch = New-Object -TypeName System.Diagnostics.Stopwatch`
`147`		`- $localTelemetryProperties = @{`
`148`		`- 'UriFragment' = $UriFragment`
`149`		`- 'WaitForCompletion' = ($WaitForCompletion -eq $true)`
`150`		`- }`
	`146`	`+ $localTelemetryProperties = @{}`
`151`	`147`	`$TelemetryProperties.Keys \| ForEach-Object { $localTelemetryProperties[$_] = $TelemetryProperties[$_] }`
`152`	`148`	`$errorBucket = $TelemetryExceptionBucket`
`153`	`149`	`if ([String]::IsNullOrEmpty($errorBucket))`
`@@ -198,13 +194,14 @@ function Invoke-GHRestMethod`
`198`	`194`	`return`
`199`	`195`	`}`
`200`	`196`
	`197`	`+ $NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus`
	`198`	`+`
`201`	`199`	`try`
`202`	`200`	`{`
`203`	`201`	`Write-Log -Message $Description -Level Verbose`
`204`	`202`	`Write-Log -Message "Accessing [$Method] $url [Timeout = $(Get-GitHubConfiguration -Name WebRequestTimeoutSec))]" -Level Verbose`
`205`	`203`
`206`	`204`	`$result = $null`
`207`		`- $NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus`
`208`	`205`	`if ($NoStatus)`
`209`	`206`	`{`
`210`	`207`	`$params = @{}`
`@@ -293,7 +290,8 @@ function Invoke-GHRestMethod`
`293`	`290`	`Write-Log -Message "Unable to retrieve the raw HTTP Web Response:" -Exception $_ -Level Warning`
`294`	`291`	`}`
`295`	`292`
`296`		`- throw (ConvertTo-Json -InputObject $ex -Depth 20)`
	`293`	`+ $jsonConversionDepth = 20 # Seems like it should be more than sufficient`
	`294`	`+ throw (ConvertTo-Json -InputObject $ex -Depth $jsonConversionDepth)`
`297`	`295`	`}`
`298`	`296`	`}`
`299`	`297`
`@@ -326,7 +324,7 @@ function Invoke-GHRestMethod`
`326`	`324`	`if (-not [String]::IsNullOrEmpty($TelemetryEventName))`
`327`	`325`	`{`
`328`	`326`	`$telemetryMetrics = @{ 'Duration' = $stopwatch.Elapsed.TotalSeconds }`
`329`		`- Set-TelemetryEvent -EventName $TelemetryEventName -Properties $localTelemetryProperties -Metrics $telemetryMetrics`
	`327`	`+ Set-TelemetryEvent -EventName $TelemetryEventName -Properties $localTelemetryProperties -Metrics $telemetryMetrics -NoStatus:$NoStatus`
`330`	`328`	`}`
`331`	`329`
`332`	`330`	`$finalResult = $result.Content`
`@@ -454,14 +452,14 @@ function Invoke-GHRestMethod`
`454`	`452`	`{`
`455`	`453`	`# Will be thrown if $ex.Message isn't JSON content`
`456`	`454`	`Write-Log -Exception $_ -Level Error`
`457`		`- Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties`
	`455`	`+ Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus`
`458`	`456`	`throw`
`459`	`457`	`}`
`460`	`458`	`}`
`461`	`459`	`else`
`462`	`460`	`{`
`463`	`461`	`Write-Log -Exception $_ -Level Error`
`464`		`- Set-TelemetryException -Exception $_.Exception -ErrorBucket $errorBucket -Properties $localTelemetryProperties`
	`462`	`+ Set-TelemetryException -Exception $_.Exception -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus`
`465`	`463`	`throw`
`466`	`464`	`}`
`467`	`465`
`@@ -524,7 +522,7 @@ function Invoke-GHRestMethod`
`524`	`522`
`525`	`523`	`$newLineOutput = ($output -join [Environment]::NewLine)`
`526`	`524`	`Write-Log -Message $newLineOutput -Level Error`
`527`		`- Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties`
	`525`	`+ Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus`
`528`	`526`	`throw $newLineOutput`
`529`	`527`	`}`
`530`	`528`	`}`