Hello,

My name is Cyrille Le Clerc, I am in charge of the Tomcat 8 support on CloudBees platform and I am interested in contributing to this enhancement.

I see many changes in the testing framework the following classes must be changed to use the Tomcat 8's org.apache.catalina.startup.Tomcat instead of Tomcat 7's org.apache.catalina.startup.Embedded:

• CouchbaseIntegrationTest
• MemcachedSessionManagerIntegrationTest
• MemcachedFailoverIntegrationTest
• NonStickySessionsIntegrationTest
• TestUtils
• TomcatBuilder
• TomcatFailoverIntegrationTest

My unit tests still don't pass but I can contribute it to this pull request whenever someone is interested.

do you want to copy the tomcat 7 tests or is your code based on one general tool that encapsulates the functionality of Embedded and Tomcat classes?

First of all thanx a lot @h0nIg for the initial pull request! I appreciate this a lot even if I didn't take time to take further steps towards tomcat8 support. Now that there are RCs available (via maven) it's easier to work on this.

@cyrille-leclerc I'd be happy if you'd contribute to this pull request!

The tests use(d) Embedded instead of Tomcat because Tomcat was introduced with tomcat7.

I think with the support for tomcat8 we can cancel tomcat6 support (split off a tomcat6 branch to be able to backport fixes if this would be needed) and move tests from Embedded to Tomcat.

@h0nIg @cyrille-leclerc WDYT?

Hi,

1. Thanks for welcoming me in the contributors club, I'll do beautiful pull requests
2. Embedded vs. Tomcat and end of support for Tomcat6: I like your idea, I gue the tomcat6 support could always be done on a branch --> I'll re-integrate my migration from Embedded to Tomcat in the shared "memcached-session-manager" project
3. Shall we continue to work on a branch name tomcat8? Would it make sense to name this branche "v2" as many things will change, at least in the testing code?
4. Can you wait until this week end for me to re-integrate these changes and share my code? I'm super busy with my day job this week

Shall we continue to work on a branch name tomcat8? Would it make sense to name this branche "v2" as many things will change, at least in the testing code?

IMHO we can continue to work on 'tomcat8' - assuming that your work is based on @h0nIg. Still, if you think it would make more sense to work on a v2 just go ahead.

Can you wait until this week end for me to re-integrate these changes and share my code? I'm super busy with my day job this week

Absolutely. I'm under very high pressure due to a preso at the end of next week, so I won't have time before in 2 weeks either (sorry for my bad english ;-)).

"Embedded vs. Tomcat and end of support for Tomcat6"

i dont think it is a very good idea to "drop" the support for tomcat 6, since tomcat will get maintenance updates as long as tomcat 9 will be released. (https://www.tomcatexpert.com/blog/2013/01/31/java-6-end-life-impact-apache-tomcat-users)

"Since the community supports 3 versions at any time, Tomcat 6 will continue to be supported until Tomcat 9 becomes active, so we should expect at least another two to three years of active support and development on Tomcat 6."

@cyrille-leclerc do you think a solution is possible that will address all active tomcat versions? or do you think that a solution with an interface/implementation per version of Tomcat and Embedded that will do the necessary work for the tests is a very bad idea/not possible?

Thanx for this information @h0nIg! Then maybe we should keep support for tomcat 6. According to the google code downloads the tomcat6 jar makes still ~35% of both tc7+tc6 downloads, and the sonatype statistics show the same ratio.

So it would be great if we could introduce an additional interface and implementations for Embedded and Tomcat.

Changes between tc7 and tc8:

Package changed

• org.apache.catalina.deploy.LoginConfig -> org.apache.tomcat.util.descriptor.web.LoginConfig
• org.apache.catalina.deploy.SecurityConstraint -> org.apache.tomcat.util.descriptor.web.SecurityConstraint

Disappeared

• org.apache.catalina.authenticator.Constants.FORM_METHOD -> replaced by raw string "FORM"

Problems

• tomcat.addWebapp(path, appBaseDir) has a problem when path = "/": request.getPathInfo() returns "//" instead of "/", I temporarily use path = "/a"

Hi, I may have made a mistake with github. I created #30 .

One test is unfortunately still failing, see pull request 30 for details.